Bug 165129 - Add simple way to implement Wasm ops that require more than one B3 opcode
Summary: Add simple way to implement Wasm ops that require more than one B3 opcode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-28 17:53 PST by Keith Miller
Modified: 2016-11-29 11:37 PST (History)
5 users (show)

See Also:

Attachments
Patch (30.18 KB, patch)
2016-11-28 18:05 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (27.83 KB, patch)
2016-11-29 04:14 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (34.21 KB, patch)
2016-11-29 11:20 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (34.21 KB, patch)
2016-11-29 11:23 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-11-28 17:53:08 PST 
Add simple way to implement Wasm ops that require more than one B3 opcode
Comment 1 Keith Miller 2016-11-28 18:05:48 PST 
Created attachment 295562 [details]
Patch
Comment 2 WebKit Commit Bot 2016-11-28 18:07:11 PST 
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Comment 3 Keith Miller 2016-11-29 04:14:47 PST 
Created attachment 295590 [details]
Patch
Comment 4 Geoffrey Garen 2016-11-29 10:28:59 PST 
Comment on attachment 295590 [details]
Patch

r=me
Comment 5 Filip Pizlo 2016-11-29 10:29:56 PST 
Comment on attachment 295590 [details]
Patch

Crazy!
Comment 6 Filip Pizlo 2016-11-29 10:30:08 PST 
(In reply to comment #5)
> Comment on attachment 295590 [details]
> Patch
> 
> Crazy!

r=me too
Comment 7 Keith Miller 2016-11-29 10:35:05 PST 
After talking to Filip offline, I think I'm going to change the arguments from $1 to @1 since that matches the B3 format.
Comment 8 Keith Miller 2016-11-29 10:35:52 PST 
It should be a trivial change so I don't think it will need another review.
Comment 9 Keith Miller 2016-11-29 11:20:01 PST 
Created attachment 295609 [details]
Patch for landing
Comment 10 Keith Miller 2016-11-29 11:23:17 PST 
Created attachment 295611 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2016-11-29 11:37:20 PST 
Comment on attachment 295611 [details]
Patch for landing

Clearing flags on attachment: 295611

Committed r209083: <http://trac.webkit.org/changeset/209083>
Comment 12 WebKit Commit Bot 2016-11-29 11:37:24 PST 
All reviewed patches have been landed.  Closing bug.