Bug 165123 - [Mac][WK2] Enable HTML interactive form validation
Summary: [Mac][WK2] Enable HTML interactive form validation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 164382
  Show dependency tree / graph
 
Reported: 2016-11-28 16:16 PST by Chris Dumez
Modified: 2016-12-08 14:13 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2016-11-28 16:18 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-11-28 16:16:36 PST 
Enable HTML interactive form validation now that we have a native UI for it.
Comment 1 Chris Dumez 2016-11-28 16:16:50 PST 
<rdar://problem/28944652>
Comment 2 Chris Dumez 2016-11-28 16:18:31 PST 
Created attachment 295549 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-11-28 16:42:13 PST 
Comment on attachment 295549 [details]
Patch

Making InteractiveFormValidationEnabled a non-experimental feature means that it won't get enabled by default in WTR, so maybe iOS-WK2 tests will be affected?
Comment 4 Chris Dumez 2016-11-28 16:43:31 PST 
(In reply to comment #3)
> Comment on attachment 295549 [details]
> Patch
> 
> Making InteractiveFormValidationEnabled a non-experimental feature means
> that it won't get enabled by default in WTR, so maybe iOS-WK2 tests will be
> affected?

Ok, I'll wait to see if iOS EWS is happy then.
Comment 5 WebKit Commit Bot 2016-11-28 21:37:30 PST 
Comment on attachment 295549 [details]
Patch

Clearing flags on attachment: 295549

Committed r209060: <http://trac.webkit.org/changeset/209060>
Comment 6 WebKit Commit Bot 2016-11-28 21:37:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2016-11-29 09:05:20 PST 
<rdar://problem/29421342>
Comment 8 m.kurz+webkitbugs 2016-12-08 13:49:05 PST 
Shouldn't bug 28649 also get marked as resolved now? Isn't it a duplicate?

What's unclear for me is if this gets rolled out both for Safari on macOS and iOS or just one of these plattforms?
Comment 9 Chris Dumez 2016-12-08 13:52:06 PST 
(In reply to comment #8)
> Shouldn't bug 28649 also get marked as resolved now? Isn't it a duplicate?
> 
> What's unclear for me is if this gets rolled out both for Safari on macOS
> and iOS or just one of these plattforms?

I duped it to https://bugs.webkit.org/show_bug.cgi?id=164382. The reason https://bugs.webkit.org/show_bug.cgi?id=164382 is not closed yet because we have not yet enabled interactive validation on iOS WebKit1.
Comment 10 m.kurz+webkitbugs 2016-12-08 14:08:08 PST 
Isn't iOS using WebKit2 since version 8 anyway? Who would be affected by fixing bug 164382?
Comment 11 Chris Dumez 2016-12-08 14:09:35 PST 
(In reply to comment #10)
> Isn't iOS using WebKit2 since version 8 anyway? Who would be affected by
> fixing bug 164382?

Apps using UIWebView instead of WKWebView.
Comment 12 m.kurz+webkitbugs 2016-12-08 14:13:12 PST 
Got it, thanks!