Bug 165114 – Add a new project for recording and playing back editing commands in editable web content

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Wenson Hsieh]

Add a new project for recording and playing back editing commands in editable web content

[Wenson Hsieh]

<rdar://problem/29408135>

[Wenson Hsieh]

Created attachment 295537 [details]
Patch

[Wenson Hsieh]

Comment on attachment 295537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295537&action=review

> Tools/ChangeLog:19
> +        2. Extract the JSON-serialized editing history data and load the playback harness with this data.

Whoops, there are two 2s here :| I'll fix this.

[Alexey Proskuryakov]

How is the playback part going to be used? WebKitTestRunner has JS functions to simulate text input functions, will this be different?

[Wenson Hsieh]

(In reply to comment #4)
> How is the playback part going to be used? WebKitTestRunner has JS functions
> to simulate text input functions, will this be different?

The purpose of this project is to provide a means for clients to remember DOM changes that occurred due to editing, and later replay these DOM changes in a separate page that allows the user to step through each of the editing actions and DOM changes that occurred, one by one. Thus, the EditingHistory project is unrelated to our testing infrastructure (e.g. TestWebKitAPI and WebKitTestRunner).

The playback part happens when the user opens the playback harness and loads a .json file containing editing history. This allows the user to 'seek' through the editing that occurred, an input at a time.

[Wenson Hsieh]

Created attachment 295662 [details]
Added highlight-able nodes in the playback harness.

[Wenson Hsieh]

Created attachment 296025 [details]
Patch

[Wenson Hsieh]

Comment on attachment 296025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296025&action=review

> Tools/EditingHistory/DumpEditingHistory.js:1
> +(() => {

Whoops, this file isn't supposed to be here. I'll remove it.

[Wenson Hsieh]

Created attachment 296028 [details]
Patch

[Beth Dakin]

Comment on attachment 296028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296028&action=review

One nit!

> Source/WebCore/ChangeLog:10
> +        scripts to the internal system directory when ionstalling. See the Tools ChangeLog and individual comments below

ionstalling -> installing :-P

[Wenson Hsieh]

Created attachment 296404 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 296404 [details]
Patch for landing

Clearing flags on attachment: 296404

Committed r209470: <http://trac.webkit.org/changeset/209470>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.