Bug 165101 - Separate UIDelegate platform specific code into UIDelegateIOS and UIDelegateMac classes.
Summary: Separate UIDelegate platform specific code into UIDelegateIOS and UIDelegateM...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-28 12:10 PST by Andrew Gold
Modified: 2016-11-29 08:58 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gold 2016-11-28 12:10:45 PST 
UIDelegate currently uses compiler flags to allow for platform specific login in UIDelegate. We should instead create subclasses UIDelegateMac and UIDelegateIOS to distinguish platform specific code.
Comment 1 Alexey Proskuryakov 2016-11-28 15:59:46 PST 
Why is that an improvement? Subclassing is used for runtime polymorphism, so it's the wrong tool to use for platform specific code.
Comment 2 Andrew Gold 2016-11-29 08:58:24 PST 
(In reply to comment #1)
> Why is that an improvement? Subclassing is used for runtime polymorphism, so
> it's the wrong tool to use for platform specific code.

Sorry, you're right, we don't want to subclass. What I meant was separate implementations so that we don't need the platform-specific compiler flags throughout UIDelegate.