NEW 165101
Separate UIDelegate platform specific code into UIDelegateIOS and UIDelegateMac classes. 
https://bugs.webkit.org/show_bug.cgi?id=165101
Summary Separate UIDelegate platform specific code into UIDelegateIOS and UIDelegateM...
Andrew Gold
Reported 2016-11-28 12:10:45 PST
UIDelegate currently uses compiler flags to allow for platform specific login in UIDelegate. We should instead create subclasses UIDelegateMac and UIDelegateIOS to distinguish platform specific code.
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-11-28 15:59:46 PST
Why is that an improvement? Subclassing is used for runtime polymorphism, so it's the wrong tool to use for platform specific code.
Andrew Gold
Comment 2 2016-11-29 08:58:24 PST
(In reply to comment #1) > Why is that an improvement? Subclassing is used for runtime polymorphism, so > it's the wrong tool to use for platform specific code. Sorry, you're right, we don't want to subclass. What I meant was separate implementations so that we don't need the platform-specific compiler flags throughout UIDelegate.
Note You need to log in before you can comment on or make changes to this bug.