Bug 165094 – [css-grid] Move more attributes from RenderGrid to the new Grid class

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sergio Villar Senin]

[css-grid] Move more attributes from RenderGrid to the new Grid class

[Sergio Villar Senin]

Created attachment 295494 [details]
Patch

[Build Bot]

Comment on attachment 295494 [details]
Patch

Attachment 295494 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2584378

New failing tests:
intersection-observer/intersection-observer-entry-interface.html

[Build Bot]

Created attachment 295520 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Sergio Villar Senin]

Ping reviewers. I know I've uploaded it quite recently but it's blocking some other patches so it'd be awesome to have it reviewed ASAP.

[Darin Adler]

Comment on attachment 295494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295494&action=review

> Source/WebCore/rendering/RenderGrid.cpp:110
> +    m_autoRepeatColumns =  autoRepeatColumns;

Extra space here after the "=".

> Source/WebCore/rendering/RenderGrid.cpp:433
> +    , m_grid(this)

Why does m_grid take a pointer rather than a reference?

> Source/WebCore/rendering/RenderGrid.h:199
> +        Grid(RenderGrid* grid)
> +            : m_orderIterator(*grid) { }

This should take a RenderGrid&, since it dereferences the pointer on the next line. Also, the formatting here isn’t really our standard. I think we’d want this all on one line.

[Sergio Villar Senin]

Comment on attachment 295494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295494&action=review

>> Source/WebCore/rendering/RenderGrid.cpp:433
>> +    , m_grid(this)
> 
> Why does m_grid take a pointer rather than a reference?

No special reason. I'll switch to a reference.

>> Source/WebCore/rendering/RenderGrid.h:199
>> +            : m_orderIterator(*grid) { }
> 
> This should take a RenderGrid&, since it dereferences the pointer on the next line. Also, the formatting here isn’t really our standard. I think we’d want this all on one line.

Right, I'll change that before landing.

[Sergio Villar Senin]

Committed r209180: <http://trac.webkit.org/changeset/209180>