Bug 165066 - Fix exception scope verification failures in ReflectObject.cpp.
Summary: Fix exception scope verification failures in ReflectObject.cpp.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 162351
  Show dependency tree / graph
 
Reported: 2016-11-24 09:26 PST by Mark Lam
Modified: 2016-11-28 14:15 PST (History)
8 users (show)

See Also:

Attachments
proposed patch. (7.24 KB, patch)
2016-11-24 09:31 PST, Mark Lam 		mark.lam: review-
Details | Formatted Diff | Diff
proposed patch. (4.62 KB, patch)
2016-11-25 14:19 PST, Mark Lam 		sbarati: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-11-24 09:26:04 PST 
Patch coming.
Comment 1 Mark Lam 2016-11-24 09:31:53 PST 
Created attachment 295416 [details]
proposed patch.
Comment 2 Mark Lam 2016-11-24 13:37:24 PST 
Comment on attachment 295416 [details]
proposed patch.

It is invalid to replace returning encodedJSValue() with returning { }.  On 32-bit builds, the former is non-zero, while the latter is 0.  Will fix this patch.
Comment 3 Mark Lam 2016-11-25 14:19:09 PST 
Created attachment 295431 [details]
proposed patch.
Comment 4 Mark Lam 2016-11-28 14:15:26 PST 
Thanks for the review.  Landed in r209015: <http://trac.webkit.org/r209015>.