Bug 165060 - Fix various --minimal build issues
Summary: Fix various --minimal build issues
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Reported: 2016-11-24 05:42 PST by Csaba Osztrogonác
Modified: 2016-11-27 10:17 PST (History)
1 user (show)

See Also:

Patch (2.73 KB, patch)
2016-11-24 05:43 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-11-24 05:42:32 PST
1.) isCustomIdentValue() is only used inside ENABLE(CSS_GRID_LAYOUT) guard,
but defined unconditionally in Source/WebCore/css/parser/CSSPropertyParser.cpp,
which caused build error if !ENABLE(CSS_GRID_LAYOUT) - unused but defined function.

2.) SecurityOriginData struct is used in Source/WebCore/loader/EmptyClients.cpp and
Source/WebCore/dom/Document.cpp too, but SecurityOriginData.h isn't directly included.
The normal full build works, because this header is included indirectly somewhere.
Comment 1 Csaba Osztrogonác 2016-11-24 05:43:34 PST
Created attachment 295405 [details]
Comment 2 WebKit Commit Bot 2016-11-27 10:17:08 PST
Comment on attachment 295405 [details]

Clearing flags on attachment: 295405

Committed r208991: <http://trac.webkit.org/changeset/208991>
Comment 3 WebKit Commit Bot 2016-11-27 10:17:11 PST
All reviewed patches have been landed.  Closing bug.