Fix exception scope verification failures in miscellaneous files.

[Mark Lam]

Patch coming.

[Mark Lam]

Created attachment 295393 [details]
proposed patch.

[Mark Lam]

Created attachment 295394 [details]
proposed patch.

[Mark Lam]

Comment on attachment 295394 [details]
proposed patch.

It is invalid to replace returning encodedJSValue() with returning { }.  On 32-bit builds, the former is non-zero, while the latter is 0.  Will fix this patch.

[Mark Lam]

Created attachment 295430 [details]
proposed patch.

[Saam Barati]

Comment on attachment 295430 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=295430&action=review

> Source/JavaScriptCore/runtime/ModuleLoaderPrototype.cpp:148
> +    if (!moduleRecord) {
> +        scope.release();

Why not just move the DECLARE_THROW_SCOPE lower?

[Mark Lam]

Comment on attachment 295430 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=295430&action=review

>> Source/JavaScriptCore/runtime/ModuleLoaderPrototype.cpp:148
>> +        scope.release();
> 
> Why not just move the DECLARE_THROW_SCOPE lower?

Because the rule of thumb is to DECLARE_THROW_SCOPE (or DECLARE_CATCH_SCOPE) as high up in the function as much as possible.  Keeping it consistent this way removes the chance of missing needed exception checks because someone declared it too late, and a function call that can throw is added subsequently before the declaration of the throw scope.

[Mark Lam]

Thanks for the review.  Landed in r209018: <http://trac.webkit.org/r209018>.