Bug 165047 - Fix exception scope verification failures in JSScope.cpp
Summary: Fix exception scope verification failures in JSScope.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 162351
  Show dependency treegraph
 
Reported: 2016-11-23 09:45 PST by Mark Lam
Modified: 2016-11-28 15:15 PST (History)
8 users (show)

See Also:


Attachments
proposed patch. (2.52 KB, patch)
2016-11-23 09:49 PST, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-11-23 09:45:04 PST
Patch coming.
Comment 1 Mark Lam 2016-11-23 09:49:52 PST
Created attachment 295371 [details]
proposed patch.
Comment 2 Saam Barati 2016-11-28 14:13:51 PST
Comment on attachment 295371 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=295371&action=review

> Source/JavaScriptCore/runtime/JSScope.cpp:-244
> -            ASSERT_WITH_MESSAGE_UNUSED(throwScope, !throwScope.exception(), "When an exception occurs, the result of isUnscopable becomes false");

Why get rid of this?
Comment 3 Mark Lam 2016-11-28 15:12:29 PST
Comment on attachment 295371 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=295371&action=review

>> Source/JavaScriptCore/runtime/JSScope.cpp:-244
>> -            ASSERT_WITH_MESSAGE_UNUSED(throwScope, !throwScope.exception(), "When an exception occurs, the result of isUnscopable becomes false");
> 
> Why get rid of this?

Because it is now redundant.  The assertion before the "if (!unscopable)" check replaces it.
Comment 4 Mark Lam 2016-11-28 15:15:47 PST
Thanks for the review.  Landed in r209028: <http://trac.webkit.org/r209028>.