Bug 165023 - Make normal case fast in the input element limitString function
Summary: Make normal case fast in the input element limitString function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-21 21:56 PST by Darin Adler
Modified: 2016-11-22 10:26 PST (History)
4 users (show)

See Also:


Attachments
Patch (46.59 KB, patch)
2016-11-21 22:13 PST, Darin Adler
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-11-21 21:56:49 PST
Make normal case fast in the input element limitString function
Comment 1 Darin Adler 2016-11-21 22:13:21 PST
Created attachment 295326 [details]
Patch
Comment 2 mitz 2016-11-21 22:36:09 PST
Comment on attachment 295326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295326&action=review

> Source/WTF/ChangeLog:27
> +        class and not repeat UAX16 in the names of the modes. Initial data members

UAX14

> Source/WebCore/html/TextFieldInputType.cpp:389
> +    auto firstBadCharacterIndex = string.find([] (UChar character) {

Maybe if we knew why we’re doing this we’d use an adjective other than “bad” here.
Comment 3 Darin Adler 2016-11-22 09:16:15 PST
Committed r208963: <http://trac.webkit.org/changeset/208963>
Comment 4 Darin Adler 2016-11-22 10:26:29 PST
Comment on attachment 295326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295326&action=review

>> Source/WebCore/html/TextFieldInputType.cpp:389
>> +    auto firstBadCharacterIndex = string.find([] (UChar character) {
> 
> Maybe if we knew why we’re doing this we’d use an adjective other than “bad” here.

I renamed to firstNonTabControlCharacterIndex.