Bug 165008 - [CMake] build fails after update to cmake 3.7
Summary: [CMake] build fails after update to cmake 3.7
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-21 07:30 PST by Philippe Normand
Modified: 2023-02-19 16:22 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2016-11-21 11:58 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2016-11-21 07:30:24 PST 
CMake Error at Source/cmake/WebKitMacros.cmake:297 (add_library):
  The install of the JavaScriptCore target requires changing an RPATH from   
  the build tree, but this is not supported with the Ninja generator unless
  on an ELF-based platform.  The CMAKE_BUILD_WITH_INSTALL_RPATH variable may 
  be set to avoid this relinking step.
Call Stack (most recent call first):
  Source/JavaScriptCore/CMakeLists.txt:1474 (WEBKIT_FRAMEWORK)
Comment 1 Philippe Normand 2016-11-21 07:40:49 PST 
This is on an amd64 machine btw.
Comment 2 Carlos Alberto Lopez Perez 2016-11-21 08:23:27 PST 
I guess it still work if you use Make instead of Ninja (by passing -G "Unix Makefiles" to CMake)


This seems to be the CMake commit causing this: https://gitlab.kitware.com/cmake/cmake/commit/72dfca30b94ba1e85533c61a7b5a330dfbc04da5
Comment 3 Carlos Alberto Lopez Perez 2016-11-21 09:31:09 PST 
Asked CMake developers about this at https://gitlab.kitware.com/cmake/cmake/issues/13934
Comment 4 Carlos Alberto Lopez Perez 2016-11-21 11:58:54 PST 
Created attachment 295309 [details]
Patch
Comment 5 Philippe Normand 2016-11-21 12:23:46 PST 
Thanks Carlos!
Comment 6 WebKit Commit Bot 2016-11-21 12:32:52 PST 
Comment on attachment 295309 [details]
Patch

Clearing flags on attachment: 295309

Committed r208951: <http://trac.webkit.org/changeset/208951>
Comment 7 WebKit Commit Bot 2016-11-21 12:32:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Fujii Hironori 2023-02-19 16:22:47 PST 
This change introduced bug#252548.
And, CMake 3.8 fixed the problem. 

https://gitlab.kitware.com/cmake/cmake/-/issues/13934#note_200624
https://gitlab.kitware.com/cmake/cmake/-/commit/25b6e7b710d7739cca44ed19bf45a190e72a6b82

I'm going to revert this change in bug#252548.