RESOLVED FIXED165008
[CMake] build fails after update to cmake 3.7 
https://bugs.webkit.org/show_bug.cgi?id=165008
Summary [CMake] build fails after update to cmake 3.7
Philippe Normand
Reported 2016-11-21 07:30:24 PST
CMake Error at Source/cmake/WebKitMacros.cmake:297 (add_library): The install of the JavaScriptCore target requires changing an RPATH from the build tree, but this is not supported with the Ninja generator unless on an ELF-based platform. The CMAKE_BUILD_WITH_INSTALL_RPATH variable may be set to avoid this relinking step. Call Stack (most recent call first): Source/JavaScriptCore/CMakeLists.txt:1474 (WEBKIT_FRAMEWORK)
Attachments
Patch (1.70 KB, patch)
2016-11-21 11:58 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2016-11-21 07:40:49 PST
This is on an amd64 machine btw.
Carlos Alberto Lopez Perez
Comment 2 2016-11-21 08:23:27 PST
I guess it still work if you use Make instead of Ninja (by passing -G "Unix Makefiles" to CMake) This seems to be the CMake commit causing this: https://gitlab.kitware.com/cmake/cmake/commit/72dfca30b94ba1e85533c61a7b5a330dfbc04da5
Carlos Alberto Lopez Perez
Comment 3 2016-11-21 09:31:09 PST
Asked CMake developers about this at https://gitlab.kitware.com/cmake/cmake/issues/13934
Carlos Alberto Lopez Perez
Comment 4 2016-11-21 11:58:54 PST
Created attachment 295309 [details] Patch
Philippe Normand
Comment 5 2016-11-21 12:23:46 PST
Thanks Carlos!
WebKit Commit Bot
Comment 6 2016-11-21 12:32:52 PST
Comment on attachment 295309 [details] Patch Clearing flags on attachment: 295309 Committed r208951: <http://trac.webkit.org/changeset/208951>
WebKit Commit Bot
Comment 7 2016-11-21 12:32:57 PST
All reviewed patches have been landed. Closing bug.
Fujii Hironori
Comment 8 2023-02-19 16:22:47 PST
This change introduced bug#252548. And, CMake 3.8 fixed the problem. https://gitlab.kitware.com/cmake/cmake/-/issues/13934#note_200624 https://gitlab.kitware.com/cmake/cmake/-/commit/25b6e7b710d7739cca44ed19bf45a190e72a6b82 I'm going to revert this change in bug#252548.
Note You need to log in before you can comment on or make changes to this bug.