Bug 164982 – Add a runtime flag for SubtleCrypto

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

Add a runtime flag for SubtleCrypto.

[Jiewen Tan]

Created attachment 295252 [details]
Patch

[Jiewen Tan]

Comment on attachment 295252 [details]
Patch

Can someone tell me why minibrowser WK2 doesn't work?

[Jiewen Tan]

Created attachment 295325 [details]
Patch

[Brent Fulgham]

(In reply to comment #2)
> Comment on attachment 295252 [details]
> Patch
> 
> Can someone tell me why minibrowser WK2 doesn't work?

I think you need to modify AppDelegate.m "defaultConfiguration" to add turn your new flag on. Otherwise it will default to off.

I assume you want to turn it on for MiniBrowser by default, not allow the user to toggle it at runtime?

[Jiewen Tan]

(In reply to comment #4)
> (In reply to comment #2)
> > Comment on attachment 295252 [details]
> > Patch
> > 
> > Can someone tell me why minibrowser WK2 doesn't work?
> 
> I think you need to modify AppDelegate.m "defaultConfiguration" to add turn
> your new flag on. Otherwise it will default to off.
> 
> I assume you want to turn it on for MiniBrowser by default, not allow the
> user to toggle it at runtime?

Thanks Brent, let me try.

[Jiewen Tan]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > Comment on attachment 295252 [details]
> > > Patch
> > > 
> > > Can someone tell me why minibrowser WK2 doesn't work?
> > 
> > I think you need to modify AppDelegate.m "defaultConfiguration" to add turn
> > your new flag on. Otherwise it will default to off.
> > 
> > I assume you want to turn it on for MiniBrowser by default, not allow the
> > user to toggle it at runtime?
> 
> Thanks Brent, let me try.

It seems like experimental features are default off. If that's the case for miniBrowser, I have no objection on it. I can use WK1 window for test purpose.

[Radar WebKit Bug Importer]

<rdar://problem/29468077>

[Brent Fulgham]

Comment on attachment 295325 [details]
Patch

Looks correct. r=me.

[Jiewen Tan]

(In reply to comment #8)
> Comment on attachment 295325 [details]
> Patch
> 
> Looks correct. r=me.

Thanks Brent for r+ my patch.

[Jiewen Tan]

Created attachment 295922 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 295922 [details]
Patch for landing

Clearing flags on attachment: 295922

Committed r209230: <http://trac.webkit.org/changeset/209230>

[Joseph Pecoraro]

Comment on attachment 295922 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=295922&action=review

> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h:372
> +#if ENABLE(SUBTLE_CRYPTO)
> +    bool m_isSubtleCryptoEnabled;
> +#endif

This member variable doesn't appear to be initialed to anything by default, or in reset(). Could this cause problems for Windows / Linux ports that doesn't explicitly set this in their WebKit APIs?