Bug 164973 – Disable #line markers in bison output on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Konstantin Tokarev]

New bison versions since 3.0 have bug that causes unescaped paths to be printed in #line directives. On Windows CMake passes absolute paths to bison that have backslashes in them, leading to compiler errors or warnings because of unrecognized escape sequences.

[Konstantin Tokarev]

Created attachment 295229 [details]
Patch

[Darin Adler]

Comment on attachment 295229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295229&action=review

> Source/WebCore/css/makegrammar.pl:83
> -system("\"$bison\" -d -p $symbolsPrefix $grammarFilePath -o $fileBase.cpp");
> +
> +my $extraArg = "";
> +if ($^O eq "MSWin32") {
> +    $extraArg = "--no-lines";
> +}
> +system("\"$bison\" $extraArg -d -p $symbolsPrefix $grammarFilePath -o $fileBase.cpp");

Here's how I would write it:

    my @noLines = ();
    push @noLines, "--no-lines" if $^O eq "MSWin32"; # Work around bug in bison >= 3.0 on Windows where it puts backslashes into #line directives.
    system($bison, @noLines, "-d", "-p", $symbolsPrefix, $grammarFilePath, "-o", "$fileBase.cpp") == 0 or die;

[Konstantin Tokarev]

What about 

  my @bisonCmd = ($bison, "-d", "-p", $symbolsPrefix, $grammarFilePath, "-o", $fileBase.cpp);
  push @bisonCmd, "--no-lines" if $^O eq "MSWin32"; # Work around bug in bison >= 3.0 on Windows where it puts backslashes into #line directives.
  system(@bisonCmd) == 0 or die;

?

[Darin Adler]

That seems fine. I would name it @bisonCommand, without abbreviating the word, though.

[Darin Adler]

(In reply to comment #3)
>   my @bisonCmd = ($bison, "-d", "-p", $symbolsPrefix, $grammarFilePath,
> "-o", $fileBase.cpp);

Need quotes around "$fileBase.cpp".

[Konstantin Tokarev]

Committed r208954: <http://trac.webkit.org/changeset/208954>