Fix exception scope verification failures in JSC profiler files.

[Mark Lam]

Patch coming.

[Mark Lam]

Created attachment 295225 [details]
proposed patch.

[Mark Lam]

Created attachment 295310 [details]
proposed patch: updated to use return { } where possible.

[Saam Barati]

Comment on attachment 295310 [details]
proposed patch: updated to use return { } where possible.

View in context: https://bugs.webkit.org/attachment.cgi?id=295310&action=review

> Source/JavaScriptCore/profiler/ProfilerCompilation.cpp:120
> +    RETURN_IF_EXCEPTION(scope, { });

Why not make these assertions in this file since this is only used for debugging?

[Mark Lam]

Comment on attachment 295310 [details]
proposed patch: updated to use return { } where possible.

View in context: https://bugs.webkit.org/attachment.cgi?id=295310&action=review

>> Source/JavaScriptCore/profiler/ProfilerCompilation.cpp:120
>> +    RETURN_IF_EXCEPTION(scope, { });
> 
> Why not make these assertions in this file since this is only used for debugging?

We were already checking for some exceptions in this code before.  In this patch, I'm filling out more exception checks.  It might be appropriate to replace all these with assertions, but that would be a change in behavior.  I'll stick with the exception checks for now.  We can consider a change of behavior to use assertions later if desired.

[Mark Lam]

Thanks for the review.  Landed in r208968: <http://trac.webkit.org/r208968>.