Bug 164964 – Fix missing exception checks in Interpreter.cpp.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Patch coming.

[Mark Lam]

Created attachment 295204 [details]
proposed patch.

[Mark Lam]

Created attachment 295308 [details]
proposed patch: updated to use return { } where possible.

[Saam Barati]

Comment on attachment 295308 [details]
proposed patch: updated to use return { } where possible.

View in context: https://bugs.webkit.org/attachment.cgi?id=295308&action=review

> Source/JavaScriptCore/interpreter/Interpreter.cpp:140
> +                    scope.release();

Why wouldn't this be an ASSERT(!scope.exception())?
Seems weird to have it be successful and throw an exception.

> Source/JavaScriptCore/interpreter/Interpreter.cpp:146
> +                    scope.release();

Ditto

[Mark Lam]

Comment on attachment 295308 [details]
proposed patch: updated to use return { } where possible.

View in context: https://bugs.webkit.org/attachment.cgi?id=295308&action=review

>> Source/JavaScriptCore/interpreter/Interpreter.cpp:140
>> +                    scope.release();
> 
> Why wouldn't this be an ASSERT(!scope.exception())?
> Seems weird to have it be successful and throw an exception.

The literal parser allocates objects, and can therefore throw OutOfMemoryErrors, StackOverflowErrors, etc.

I'm going to update and land this patch.

[Mark Lam]

Created attachment 304522 [details]
Re-based patch for landing.

[Radar WebKit Bug Importer]

<rdar://problem/31071591>

[Mark Lam]

Thanks for the review.  Landed in r214005: <http://trac.webkit.org/r214005>.