Bug 164959 - Fix missing exception checks in JSC inspector files.
Summary: Fix missing exception checks in JSC inspector files.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 162351
  Show dependency treegraph
 
Reported: 2016-11-18 14:53 PST by Mark Lam
Modified: 2016-11-19 00:04 PST (History)
9 users (show)

See Also:


Attachments
proposed patch. (8.19 KB, patch)
2016-11-18 14:56 PST, Mark Lam
no flags Details | Formatted Diff | Diff
revised to have returns immediately following scope.release()s. (8.19 KB, patch)
2016-11-18 15:16 PST, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff
patch for landing. (8.62 KB, patch)
2016-11-18 16:38 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-11-18 14:53:38 PST
Patch coming.
Comment 1 Mark Lam 2016-11-18 14:56:09 PST
Created attachment 295197 [details]
proposed patch.
Comment 2 Mark Lam 2016-11-18 15:16:26 PST
Created attachment 295200 [details]
revised to have returns immediately following scope.release()s.
Comment 3 Mark Lam 2016-11-18 16:21:04 PST
Comment on attachment 295200 [details]
revised to have returns immediately following scope.release()s.

View in context: https://bugs.webkit.org/attachment.cgi?id=295200&action=review

> Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:274
> +            scope.release();
>              array->putDirectIndex(exec, index++, constructInternalProperty(exec, ASCIILiteral("status"), jsNontrivialString(exec, ASCIILiteral("pending"))));
>              break;

Thanks for the review.  I just realized that I uploaded the wrong version of the patch.  The updated one should return shortly after the call to scope.release().  The change is minor.  I'll upload the modified patch for landing.
Comment 4 Mark Lam 2016-11-18 16:38:40 PST
Created attachment 295219 [details]
patch for landing.
Comment 5 WebKit Commit Bot 2016-11-19 00:03:56 PST
Comment on attachment 295219 [details]
patch for landing.

Clearing flags on attachment: 295219

Committed r208923: <http://trac.webkit.org/changeset/208923>
Comment 6 WebKit Commit Bot 2016-11-19 00:04:00 PST
All reviewed patches have been landed.  Closing bug.