Patch coming.
Created attachment 295196 [details] proposed patch.
Comment on attachment 295196 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295196&action=review r=me > Source/JavaScriptCore/dfg/DFGOperations.cpp:144 > + if (Optional<uint32_t> index = parseIndex(propertyName)) { > + scope.release(); > asObject(baseValue)->putDirectIndex(exec, index.value(), value, 0, strict ? PutDirectIndexShouldThrow : PutDirectIndexShouldNotThrow); > - else > + } else > asObject(baseValue)->putDirect(*vm, propertyName, value, slot); > - } else > + } else { > + scope.release(); > baseValue.put(exec, propertyName, value, slot); > + } > } It's a little sketchy to have a scope.release() not immediately before a return. I think we should switch the if/else format to if/return.
Created attachment 295198 [details] patch for landing. Thanks for the review. I applied the suggested change.
Comment on attachment 295198 [details] patch for landing. Clearing flags on attachment: 295198 Committed r208913: <http://trac.webkit.org/changeset/208913>
All reviewed patches have been landed. Closing bug.