Bug 164955 - Assertion failures in ActiveDOMObject::~ActiveDOMObject under Database destructor
Summary: Assertion failures in ActiveDOMObject::~ActiveDOMObject under Database destru...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-18 14:11 PST by Chris Dumez
Modified: 2016-11-18 16:38 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2016-11-18 14:15 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-11-18 14:11:25 PST 
Assertion failures in ActiveDOMObject::~ActiveDOMObject under Database destructor:
Thread 33 Crashed:: WebCore: Database
0   com.apple.JavaScriptCore      	0x0000000107739207 WTFCrash + 39
1   com.apple.WebCore             	0x0000000111220673 WebCore::ActiveDOMObject::~ActiveDOMObject() + 211
2   com.apple.WebCore             	0x0000000111823c80 WebCore::DatabaseContext::~DatabaseContext() + 288
3   com.apple.WebCore             	0x0000000111823ca5 WebCore::DatabaseContext::~DatabaseContext() + 21
4   com.apple.WebCore             	0x0000000111823cc9 WebCore::DatabaseContext::~DatabaseContext() + 25
5   com.apple.WebCore             	0x000000011181a863 WTF::ThreadSafeRefCounted<WebCore::DatabaseContext>::deref() const + 83
6   com.apple.WebCore             	0x000000011181a807 WTF::Ref<WebCore::DatabaseContext>::~Ref() + 55
7   com.apple.WebCore             	0x0000000111814c25 WTF::Ref<WebCore::DatabaseContext>::~Ref() + 21
8   com.apple.WebCore             	0x000000011180dbb5 WebCore::Database::~Database() + 421
9   com.apple.WebCore             	0x000000011180dc65 WebCore::Database::~Database() + 21
10  com.apple.WebCore             	0x000000011181dea9 WTF::ThreadSafeRefCounted<WebCore::Database>::deref() const + 73
11  com.apple.WebCore             	0x000000011182a534 void WTF::derefIfNotNull<WebCore::Database>(WebCore::Database*) + 52
12  com.apple.WebCore             	0x000000011182a4f3 WTF::RefPtr<WebCore::Database>::~RefPtr() + 83
13  com.apple.WebCore             	0x0000000111826bb5 WTF::RefPtr<WebCore::Database>::~RefPtr() + 21
14  com.apple.WebCore             	0x000000011182d984 WTF::HashTable<WTF::RefPtr<WebCore::Database>, WTF::RefPtr<WebCore::Database>, WTF::IdentityExtractor, WTF::PtrHash<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> > >::deallocateTable(WTF::RefPtr<WebCore::Database>*, unsigned int) + 84
15  com.apple.WebCore             	0x000000011182d75e WTF::HashTable<WTF::RefPtr<WebCore::Database>, WTF::RefPtr<WebCore::Database>, WTF::IdentityExtractor, WTF::PtrHash<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> > >::~HashTable() + 62
16  com.apple.WebCore             	0x000000011182d715 WTF::HashTable<WTF::RefPtr<WebCore::Database>, WTF::RefPtr<WebCore::Database>, WTF::IdentityExtractor, WTF::PtrHash<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> > >::~HashTable() + 21
17  com.apple.WebCore             	0x000000011182d6f5 WTF::HashSet<WTF::RefPtr<WebCore::Database>, WTF::PtrHash<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> > >::~HashSet() + 21
18  com.apple.WebCore             	0x000000011182cf75 WTF::HashSet<WTF::RefPtr<WebCore::Database>, WTF::PtrHash<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> > >::~HashSet() + 21
19  com.apple.WebCore             	0x000000011182c0d7 WebCore::DatabaseThread::databaseThread() + 1095
20  com.apple.WebCore             	0x000000011182bc1d WebCore::DatabaseThread::databaseThreadStart(void*) + 29
21  com.apple.JavaScriptCore      	0x00000001077b29f9 WTF::createThread(void (*)(void*), void*, char const*)::$_0::operator()() const + 25
22  com.apple.JavaScriptCore      	0x00000001077b29cd void std::__1::__invoke_void_return_wrapper<void>::__call<WTF::createThread(void (*)(void*), void*, char const*)::$_0&>(WTF::createThread(void (*)(void*), void*, char const*)::$_0&&&) + 45
23  com.apple.JavaScriptCore      	0x00000001077b296c std::__1::__function::__func<WTF::createThread(void (*)(void*), void*, char const*)::$_0, std::__1::allocator<WTF::createThread(void (*)(void*), void*, char const*)::$_0>, void ()>::operator()() + 44
24  com.apple.JavaScriptCore      	0x0000000106caa6ea std::__1::function<void ()>::operator()() const + 26
25  com.apple.JavaScriptCore      	0x00000001077b15ce WTF::threadEntryPoint(void*) + 158
26  com.apple.JavaScriptCore      	0x00000001077b3071 WTF::wtfThreadEntryPoint(void*) + 289
27  libsystem_pthread.dylib       	0x000000011dc2899d _pthread_body + 131
28  libsystem_pthread.dylib       	0x000000011dc2891a _pthread_start + 168
29  libsystem_pthread.dylib       	0x000000011dc26351 thread_start + 13
Comment 1 Chris Dumez 2016-11-18 14:11:51 PST 
<rdar://problem/29336715>
Comment 2 Chris Dumez 2016-11-18 14:15:00 PST 
Created attachment 295191 [details]
Patch
Comment 3 Chris Dumez 2016-11-18 16:38:51 PST 
Comment on attachment 295191 [details]
Patch

Clearing flags on attachment: 295191

Committed r208908: <http://trac.webkit.org/changeset/208908>
Comment 4 Chris Dumez 2016-11-18 16:38:56 PST 
All reviewed patches have been landed.  Closing bug.