https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/4252 ** The following JSC stress test failures have been introduced: stress/op_div-ConstVar.js.misc-ftl-no-cjit stress/op_div-VarConst.js.misc-ftl-no-cjit stress/op_div-VarVar.js.misc-ftl-no-cjit stress/op_mod-ConstVar.js.misc-ftl-no-cjit stress/op_mod-VarConst.js.misc-ftl-no-cjit stress/op_mod-VarVar.js.misc-ftl-no-cjit
Another instance seen here: https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/4226 ** The following JSC stress test failures have been introduced: stress/op_div-VarConst.js.misc-ftl-no-cjit stress/op_mod-ConstVar.js.misc-ftl-no-cjit stress/op_mod-VarConst.js.misc-ftl-no-cjit stress/op_mod-VarVar.js.misc-ftl-no-cjit
These are all due to time outs. When did these failures started happening? Either we started running on slower bots or potentially, someone introduced a perf regression.
(In reply to comment #2) > These are all due to time outs. When did these failures started happening? > Either we started running on slower bots or potentially, someone introduced > a perf regression. I'm going through logs now to try to find out.
Earliest instance I can find on this bot is r208607 / Fri Nov 11 13:56:25 2016 https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/4192
The bot config has not changed.
Created attachment 295255 [details] proposed patch. I'm fixing this by simply recognizing that not all tests are equal, and that some just needs more time to run. I've added a --timeoutMultipler=<multiplier> option that can be used on these slower tests to increase their timeout duration. This should fix this issue for good.
Comment on attachment 295255 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295255&action=review r=me > Source/JavaScriptCore/jsc.cpp:2606 > + auto timeout = std::chrono::microseconds(static_cast<std::chrono::microseconds::rep>(timeoutDuration * 1000000)); Let's use WTF::Seconds.
Thanks for the review. I've changed the timeout thread to use WTF::Seconds. Landed in r208925: <http://trac.webkit.org/r208925>.
I forgot to also lengthen the timeout for op_mod-* tests. Will do that in https://bugs.webkit.org/show_bug.cgi?id=164994.
*** Bug 155289 has been marked as a duplicate of this bug. ***