Bug 16495 - [GTK] Accessibility support with ATK/AT-SPI
Summary: [GTK] Accessibility support with ATK/AT-SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 21546
  Show dependency tree / graph
 
Reported: 2007-12-17 17:14 PST by Alp Toker
Modified: 2008-10-11 17:14 PDT (History)
6 users (show)

See Also:

Attachments
Add initial accessibility support for GTK+ with ATK (19.33 KB, patch)
2008-05-19 17:02 PDT, Alp Toker 		bdakin: review+
Details | Formatted Diff | Diff
Revised coding style suggested by andersca (19.47 KB, patch)
2008-05-19 18:07 PDT, Alp Toker 		andersca: review+
Details | Formatted Diff | Diff
AT-SPI accessibility enhancements (22.41 KB, patch)
2008-05-25 05:18 PDT, Alp Toker 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-12-17 17:14:08 PST 
The GTK+ port needs ATK/accessibility support.
Comment 1 Alp Toker 2008-05-19 17:02:41 PDT 
Created attachment 21241 [details]
Add initial accessibility support for GTK+ with ATK

There are a couple of commented out lines of code but I'd like to leave them there since they're easy to miss and need to be implemented.
Comment 2 Beth Dakin 2008-05-19 17:54:10 PDT 
Comment on attachment 21241 [details]
Add initial accessibility support for GTK+ with ATK

Looks good!
Comment 3 Alp Toker 2008-05-19 18:07:20 PDT 
Created attachment 21242 [details]
Revised coding style suggested by andersca
Comment 4 Anders Carlsson 2008-05-19 18:09:32 PDT 
Comment on attachment 21242 [details]
Revised coding style suggested by andersca

r=me
Comment 5 Alp Toker 2008-05-19 18:13:58 PDT 
Landed in r33591. This will need a bit more work to provide complete accessibility support in upcoming patches.
Comment 6 Alp Toker 2008-05-25 05:07:10 PDT 
Will use this as a tracking bug since people are already CC'ed.
Comment 7 Alp Toker 2008-05-25 05:18:48 PDT 
Created attachment 21334 [details]
AT-SPI accessibility enhancements

With these changes accessibility starts to become usable. There are still many TODOs and FIXMEs.
Comment 8 Anders Carlsson 2008-05-26 09:41:03 PDT 
Comment on attachment 21334 [details]
AT-SPI accessibility enhancements


>+// Used to provide const gchar* returns.
>+static const char* returnString(String str)

This should take a const String&

I'm not too fond of the #if 0 and commented out code, but I think it might be OK for now.

r=me
Comment 9 Mark Rowe (bdash) 2008-05-26 21:18:30 PDT 
All patches associated with this bug have been landed.  Please file new bugs about any remaining work that needs to be completed on this feature.