Bug 164941 - WebKit nightly fails to build
Summary: WebKit nightly fails to build
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-18 11:55 PST by Beth Dakin
Modified: 2016-11-18 14:03 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.22 KB, patch)
2016-11-18 11:57 PST, Beth Dakin 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2016-11-18 11:55:11 PST 
WebKit nightly fails to build

In file included from /WebKit/208883/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:33:
/WebKit/208883/Source/WebCore/platform/spi/cocoa/AVKitSPI.h:174:40: error: unknown type name 'NSTouchBar'; did you mean 'NSTouch'?
@property (strong, readonly, nullable) NSTouchBar *touchBar;
                                       ^~~~~~~~~~
                                       NSTouch

rdar://problem/29332858
Comment 1 Beth Dakin 2016-11-18 11:57:40 PST 
Created attachment 295172 [details]
Patch
Comment 2 Daniel Bates 2016-11-18 12:28:05 PST 
Comment on attachment 295172 [details]
Patch

This looks sane to me.

r=me
Comment 3 Beth Dakin 2016-11-18 14:03:32 PST 
Actually we realized that this won't work. We are going to have to fix this with the SDK instead.