Bug 164935 – [WebIDL] Add support for record types

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[WebIDL] Add support for record types

[Sam Weinig]

Created attachment 295165 [details]
Patch

[WebKit Commit Bot]

Attachment 295165 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:1092:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:1097:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:1098:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 3 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 295165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295165&action=review

Very red.

> Source/WebCore/bindings/js/JSDOMConvert.h:1122
> +                //     1. If types includes a dictionary type, then return the result of converting V to that dictionary type.

Too many leading spaces?

[Build Bot]

Comment on attachment 295165 [details]
Patch

Attachment 295165 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2537924

New failing tests:
js/dom/webidl-type-mapping.html

[Build Bot]

Created attachment 295173 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Sam Weinig]

Created attachment 295174 [details]
Patch

[WebKit Commit Bot]

Attachment 295174 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:1092:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:1097:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:1098:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 3 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 295174 [details]
Patch

Attachment 295174 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2538247

New failing tests:
js/dom/webidl-type-mapping.html

[Build Bot]

Created attachment 295181 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295174 [details]
Patch

Attachment 295174 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2538264

New failing tests:
js/dom/webidl-type-mapping.html

[Build Bot]

Created attachment 295182 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295174 [details]
Patch

Attachment 295174 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2538282

New failing tests:
js/dom/webidl-type-mapping.html

[Build Bot]

Created attachment 295183 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295174 [details]
Patch

Attachment 295174 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2538276

New failing tests:
js/dom/webidl-type-mapping.html

[Build Bot]

Created attachment 295186 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Sam Weinig]

Committed r208893: <http://trac.webkit.org/changeset/208893>