Bug 164933 - REGRESSION (r208865?): [mac-wk1] LayoutTest http/tests/misc/link-rel-icon-beforeload.html is failing
Summary: REGRESSION (r208865?): [mac-wk1] LayoutTest http/tests/misc/link-rel-icon-bef...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-18 10:10 PST by Ryan Haddad
Modified: 2023-09-13 21:39 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-11-18 10:10:43 PST
LayoutTest http/tests/misc/link-rel-icon-beforeload.html is failing

https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK1%20(Tests)/r208884%20(19808)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fmisc%2Flink-rel-icon-beforeload.html

--- /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/http/tests/misc/link-rel-icon-beforeload-expected.txt
+++ /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/http/tests/misc/link-rel-icon-beforeload-actual.txt
@@ -1,5 +1,5 @@
 http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html - didFinishLoading
 http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html, main document URL http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html, http method GET> redirectResponse (null)
 http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html - didReceiveResponse <NSURLResponse http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html, http status code 200>
-http://127.0.0.1:8000/favicon.ico - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/favicon.ico, main document URL http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html, http method GET> redirectResponse (null)
+http://127.0.0.1:8000/misc/resources/favicon.ico - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/misc/resources/favicon.ico, main document URL http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html, http method GET> redirectResponse (null)
 This test should not show a request for the favicon dont-load-this.ico, since the beforeload handler on the favicon link returns false. Therefore, if the resource request list below shows a request for dont-load-this.ico, then this test has failed.
Comment 1 Ryan Haddad 2016-11-18 10:11:25 PST
This appears to have regressed in this range:
https://trac.webkit.org/log/?verbose=on&rev=208867&stop_rev=208863
Comment 2 Ryan Haddad 2016-11-18 11:19:48 PST
Of those changes, this seems like a contender: https://trac.webkit.org/changeset/208865
Comment 3 Brady Eidson 2016-11-18 13:53:11 PST
Huh, EWS didn't catch this :(

This is not an important regression and we should just skip for now. It will be an easy fix, but I can't do it right now.
Comment 4 Ryan Haddad 2016-11-18 14:05:05 PST
Marked test as failing on mac-wk1 in http://trac.webkit.org/projects/webkit/changeset/208896
Comment 5 Ben Schwartz 2023-09-13 21:39:28 PDT
This appears to be fixed in a recent commit. Ryan please verify.