Bug 164924 - Salt network cache hashes
Summary: Salt network cache hashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-18 06:41 PST by Antti Koivisto
Modified: 2016-12-08 11:58 PST (History)
8 users (show)

See Also:


Attachments
patch (25.76 KB, patch)
2016-11-18 07:04 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (25.83 KB, patch)
2016-11-18 07:46 PST, Antti Koivisto
achristensen: review+
Details | Formatted Diff | Diff
patch for landing (26.03 KB, patch)
2016-11-19 05:22 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
revert patch (25.45 KB, patch)
2016-12-01 11:26 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch for landing 2 (26.85 KB, patch)
2016-12-08 07:29 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-11-18 06:41:00 PST
Enhance privacy.
Comment 1 Antti Koivisto 2016-11-18 07:04:19 PST
Created attachment 295149 [details]
patch
Comment 2 WebKit Commit Bot 2016-11-18 07:06:35 PST
Attachment 295149 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2016-11-18 07:29:25 PST
rdar://problem/29292717
Comment 4 Antti Koivisto 2016-11-18 07:46:27 PST
Created attachment 295150 [details]
patch
Comment 5 WebKit Commit Bot 2016-11-18 07:47:51 PST
Attachment 295150 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alex Christensen 2016-11-18 08:27:54 PST
Comment on attachment 295150 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295150&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.cpp:104
>      SHA1 sha1;

If we're really trying to make this more unidentifiable, should we be using SHA1?
Comment 7 Alex Christensen 2016-11-18 13:53:44 PST
Comment on attachment 295150 [details]
patch

doesn't have to be cryptographically secure.  r=me
Comment 8 Antti Koivisto 2016-11-19 05:22:49 PST
Created attachment 295263 [details]
patch for landing

A bit more conservative version that still keeps the partition directories but names them with salted hashes. There might be performance benefits in keeping files in a single partition together.
Comment 9 WebKit Commit Bot 2016-11-19 05:25:18 PST
Attachment 295263 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Commit Bot 2016-11-19 16:38:18 PST
Comment on attachment 295263 [details]
patch for landing

Clearing flags on attachment: 295263

Committed r208931: <http://trac.webkit.org/changeset/208931>
Comment 11 WebKit Commit Bot 2016-11-19 16:38:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Antti Koivisto 2016-12-01 11:26:58 PST
Created attachment 295871 [details]
revert patch
Comment 13 Antti Koivisto 2016-12-01 11:27:35 PST
Reverting due to PLT regression.
Comment 14 WebKit Commit Bot 2016-12-01 11:29:29 PST
Attachment 295871 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:155:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:178:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 Antti Koivisto 2016-12-01 11:31:52 PST
Reverted in https://trac.webkit.org/r209189
Comment 16 Antti Koivisto 2016-12-08 07:29:55 PST
Created attachment 296511 [details]
patch for landing 2
Comment 17 WebKit Commit Bot 2016-12-08 08:17:29 PST
Attachment 296511 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 18 WebKit Commit Bot 2016-12-08 11:58:50 PST
Comment on attachment 296511 [details]
patch for landing 2

Clearing flags on attachment: 296511

Committed r209554: <http://trac.webkit.org/changeset/209554>
Comment 19 WebKit Commit Bot 2016-12-08 11:58:55 PST
All reviewed patches have been landed.  Closing bug.