Bug 164924 – Salt network cache hashes

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Antti Koivisto]

Enhance privacy.

[Antti Koivisto]

Created attachment 295149 [details]
patch

[WebKit Commit Bot]

Attachment 295149 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

rdar://problem/29292717

[Antti Koivisto]

Created attachment 295150 [details]
patch

[WebKit Commit Bot]

Attachment 295150 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 295150 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295150&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.cpp:104
>      SHA1 sha1;

If we're really trying to make this more unidentifiable, should we be using SHA1?

[Alex Christensen]

Comment on attachment 295150 [details]
patch

doesn't have to be cryptographically secure.  r=me

[Antti Koivisto]

Created attachment 295263 [details]
patch for landing

A bit more conservative version that still keeps the partition directories but names them with salted hashes. There might be performance benefits in keeping files in a single partition together.

[WebKit Commit Bot]

Attachment 295263 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 295263 [details]
patch for landing

Clearing flags on attachment: 295263

Committed r208931: <http://trac.webkit.org/changeset/208931>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Antti Koivisto]

Created attachment 295871 [details]
revert patch

[Antti Koivisto]

Reverting due to PLT regression.

[WebKit Commit Bot]

Attachment 295871 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:155:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:178:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Reverted in https://trac.webkit.org/r209189

[Antti Koivisto]

Created attachment 296511 [details]
patch for landing 2

[WebKit Commit Bot]

Attachment 296511 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 296511 [details]
patch for landing 2

Clearing flags on attachment: 296511

Committed r209554: <http://trac.webkit.org/changeset/209554>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.