Bug 164917 – [GTK] Crash in WebCore::PlatformDisplayX11::supportsXComposite when running under Wayland

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Crash in WebCore::PlatformDisplayX11::supportsXComposite when running under Wayland. This is an epiphany-search-provider crash. I wonder how we created a PlatformDisplayX11 at all:

Truncated backtrace:
Thread no. 1 (10 frames)
 #0 XQueryExtension at QuExt.c:43
 #1 XInitExtension at InitExt.c:47
 #2 XCompositeExtAddDisplay at Xcomposite.c:111
 #3 XCompositeFindDisplay at Xcomposite.c:208
 #4 XCompositeQueryExtension at Xcomposite.c:219
 #5 WebCore::PlatformDisplayX11::supportsXComposite at /usr/src/debug/webkitgtk-2.14.1/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:80
 #6 WebKit::WebPreferences::platformInitializeStore at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp:63
 #7 WebKit::WebPreferences::create at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/WebPreferences.cpp:43
 #8 WebKit::WebPreferences::createWithLegacyDefaults at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/WebPreferences.cpp:48
 #9 WebKit::WebPageGroup::WebPageGroup at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/WebPageGroup.cpp:93

Full backtrace downstream.

[Carlos Garcia Campos]

Why does ephy search provider use WebKit at all? WebKit requires a display to work, so when the shared display is created we try to guess the display to create. In the GTK+ port we ask gtk+ first for the default display, if the application called gtk_init we will always have either a X11 or Wayland display. If application didn't call gtk_init, we create our own display that is X11 display if webkit is built with X11 support. We should try to connect to wayland first and then to X11, like gtk+ does.

[Carlos Garcia Campos]

Created attachment 295408 [details]
Patch

I think this should work.

[Carlos Garcia Campos]

I don't know why it fails to build in the bots, it builds fine locally.

[Carlos Garcia Campos]

Created attachment 295412 [details]
Try to fix the build on the bots

[Carlos Garcia Campos]

Created attachment 295413 [details]
Fix EFL build

[Carlos Garcia Campos]

Created attachment 295415 [details]
Fix EFL build

[Michael Catanzaro]

(In reply to comment #1)
> Why does ephy search provider use WebKit at all?

https://bugzilla.gnome.org/show_bug.cgi?id=741595

Not sure if it can be avoided because that was two years ago and the bug doesn't have a backtrace. :(

[Michael Catanzaro]

Ah here's a backtrace: https://bugzilla.redhat.com/show_bug.cgi?id=1174007

Looks like the search provider was trying to import bookmarks from Firefox. Wow.

[Michael Catanzaro]

Comment on attachment 295415 [details]
Fix EFL build

View in context: https://bugs.webkit.org/attachment.cgi?id=295415&action=review

Thanks.

> Source/WebCore/platform/graphics/PlatformDisplay.h:74
> +    PlatformDisplay(NativeDisplayOwned = NativeDisplayOwned::No);

It doesn't matter much because the constructor is protected and not public, but without the explicit keyword you've created an implicit conversion between NativeDisplayOwned and PlatformDisplay, which is definitely undesired. So please add the explicit keyword before landing. Also, consider getting rid of the default argument. Our code will be more robust to future modification if you have to always pass NativeDisplayOwned when creating the display.

[Carlos Garcia Campos]

Committed r209064: <http://trac.webkit.org/changeset/209064>