Bug 164903 - TextDecoder constructor should not accept replacement encodings
Summary: TextDecoder constructor should not accept replacement encodings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-17 19:31 PST by Alex Christensen
Modified: 2016-11-18 16:59 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.47 KB, patch)
2016-11-17 19:34 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (3.80 KB, patch)
2016-11-17 21:27 PST, Alex Christensen 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-11-17 19:31:11 PST 
TextDecoder constructor should not accept replacement encodings
Comment 1 Alex Christensen 2016-11-17 19:34:15 PST 
Created attachment 295126 [details]
Patch
Comment 2 WebKit Commit Bot 2016-11-17 19:37:07 PST 
Attachment 295126 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2016-11-17 21:27:08 PST 
Created attachment 295134 [details]
Patch
Comment 4 Chris Dumez 2016-11-18 15:42:56 PST 
Comment on attachment 295134 [details]
Patch

r=me
Comment 5 Alex Christensen 2016-11-18 16:59:13 PST 
http://trac.webkit.org/changeset/208909