Bug 164901 - [WebIDL] Add support for ByteString
Summary: [WebIDL] Add support for ByteString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-17 17:27 PST by Sam Weinig
Modified: 2016-11-17 21:07 PST (History)
2 users (show)

See Also:

Attachments
Patch (13.30 KB, patch)
2016-11-17 17:32 PST, Sam Weinig 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-11-17 17:27:54 PST 
[WebIDL] Add support for ByteString
Comment 1 Sam Weinig 2016-11-17 17:32:30 PST 
Created attachment 295114 [details]
Patch
Comment 2 Darin Adler 2016-11-17 20:12:48 PST 
Comment on attachment 295114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295114&action=review

> Source/WebCore/bindings/js/JSDOMConvert.h:734
> +        if (configuration == StringConversionConfiguration::TreatNullAsEmptyString) {
> +            if (value.isNull())

Maybe && instead of nested if statements?

> Source/WebCore/bindings/js/JSDOMConvert.h:743
> +    static constexpr bool needsState = true;
> +    static constexpr bool needsGlobalObject = false;

Does a constexpr really need to also be marked static?

> Source/WebCore/bindings/scripts/CodeGenerator.pm:70
>      "DOMString" => 1,
> +    "ByteString" => 1,
>      "USVString" => 1,

Alphabetical instead?
Comment 3 Sam Weinig 2016-11-17 21:07:29 PST 
Committed r208876: <http://trac.webkit.org/changeset/208876>