RESOLVED FIXED 164869
Add support for rotate in B3 and the relevant assemblers 
https://bugs.webkit.org/show_bug.cgi?id=164869
Summary Add support for rotate in B3 and the relevant assemblers
Keith Miller
Reported 2016-11-17 08:57:42 PST
Add support for rotate in B3 and the relevant assemblers
Attachments
Patch (34.48 KB, patch)
2016-11-17 09:07 PST, Keith Miller 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-11-17 09:07:25 PST
Created attachment 295051 [details] Patch
Geoffrey Garen
Comment 2 2016-11-17 09:34:39 PST
Comment on attachment 295051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295051&action=review r=me > Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:670 > + void rotateRight32(RegisterID src, TrustedImm32 imm, RegisterID dest) > + { > + m_assembler.ror<32>(dest, src, imm.m_value & 31); > + } It looks like this would transform an identity rotation into a non-identity rotation. Is that desirable?
Mark Lam
Comment 3 2016-11-17 09:35:46 PST
Comment on attachment 295051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295051&action=review > Source/JavaScriptCore/ChangeLog:14 > + ammount by the value. Additionally, this patch refactors some /ammount/amount/
Keith Miller
Comment 4 2016-11-17 09:44:15 PST
Comment on attachment 295051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295051&action=review >> Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:670 >> + } > > It looks like this would transform an identity rotation into a non-identity rotation. Is that desirable? AFAIK, ARM doesn't specify what happens when the immediate is > 31. This matches the behavior if the immediate was put into a register.
Keith Miller
Comment 5 2016-11-17 09:44:28 PST
Comment on attachment 295051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295051&action=review >> Source/JavaScriptCore/ChangeLog:14 >> + ammount by the value. Additionally, this patch refactors some > > /ammount/amount/ fixed.
Keith Miller
Comment 6 2016-11-17 09:52:11 PST
Committed r208848: <http://trac.webkit.org/changeset/208848>
Note You need to log in before you can comment on or make changes to this bug.