Bug 164859 – [JSC] Drop arguments.caller

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

https://github.com/tc39/ecma262/pull/689
ES2017 drops `arguments.caller`. Chrome 56 dropped it.
Now it is included in kangax compat table.

[Yusuke Suzuki]

It's not Function#caller. Arguments#caller.

[Yusuke Suzuki]

Created attachment 295042 [details]
Patch

WIP

[Build Bot]

Comment on attachment 295042 [details]
Patch

Attachment 295042 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2531122

New failing tests:
js/strict-throw-type-error.html
js/basic-strict-mode.html
js/throw-type-error-is-unique.html

[Build Bot]

Created attachment 295044 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295042 [details]
Patch

Attachment 295042 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2531127

New failing tests:
js/strict-throw-type-error.html
js/basic-strict-mode.html
js/throw-type-error-is-unique.html

[Build Bot]

Created attachment 295045 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295042 [details]
Patch

Attachment 295042 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2531153

New failing tests:
js/strict-throw-type-error.html
js/basic-strict-mode.html
js/throw-type-error-is-unique.html

[Build Bot]

Created attachment 295046 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295042 [details]
Patch

Attachment 295042 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2531190

New failing tests:
js/strict-throw-type-error.html
js/basic-strict-mode.html
js/throw-type-error-is-unique.html

[Build Bot]

Created attachment 295047 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Yusuke Suzuki]

Created attachment 295095 [details]
Patch

[Build Bot]

Comment on attachment 295095 [details]
Patch

Attachment 295095 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2533865

New failing tests:
js/strict-throw-type-error.html
js/basic-strict-mode.html

[Build Bot]

Created attachment 295105 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Yusuke Suzuki]

Created attachment 295107 [details]
Patch

[Saam Barati]

Comment on attachment 295107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295107&action=review

> LayoutTests/js/basic-strict-mode-expected.txt:188
> +FAIL (function f(arg){'use strict'; return Object.getOwnPropertyDescriptor(arguments, 'caller').value; })() should be undefined. Threw exception TypeError: undefined is not an object (evaluating 'Object.getOwnPropertyDescriptor(arguments, 'caller').value')
> +FAIL (function f(arg){'use strict'; var descriptor = Object.getOwnPropertyDescriptor(arguments, 'caller'); return descriptor.get === descriptor.set; })() should be true. Threw exception TypeError: undefined is not an object (evaluating 'descriptor.get')

Can you fix this?

[Yusuke Suzuki]

Comment on attachment 295107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295107&action=review

>> LayoutTests/js/basic-strict-mode-expected.txt:188
>> +FAIL (function f(arg){'use strict'; var descriptor = Object.getOwnPropertyDescriptor(arguments, 'caller'); return descriptor.get === descriptor.set; })() should be true. Threw exception TypeError: undefined is not an object (evaluating 'descriptor.get')
> 
> Can you fix this?

Oops! I missed it. Fixed.

[Yusuke Suzuki]

Committed r208867: <http://trac.webkit.org/changeset/208867>