Bug 164852 - REGRESSION(r208082): 1% Speedometer regression on iOS
Summary: REGRESSION(r208082): 1% Speedometer regression on iOS
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-16 19:18 PST by Ryosuke Niwa
Modified: 2016-11-18 23:37 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.12 KB, patch)
2016-11-16 19:28 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (8.40 KB, patch)
2016-11-16 19:57 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-11-16 19:18:48 PST 
Temporarily disable CEReactions entirely to recover this regression.
Comment 1 Ryosuke Niwa 2016-11-16 19:28:39 PST 
Created attachment 295018 [details]
Patch
Comment 2 Chris Dumez 2016-11-16 19:37:16 PST 
Comment on attachment 295018 [details]
Patch

I don't mind this but wouldn't be be simpler/better to comment out support for [CEReactions] in the bindings generator?
Comment 3 Ryosuke Niwa 2016-11-16 19:45:15 PST 
(In reply to comment #2)
> Comment on attachment 295018 [details]
> Patch
> 
> I don't mind this but wouldn't be be simpler/better to comment out support
> for [CEReactions] in the bindings generator?

There are CustomElementReactionStack allocated in custom binding code as well. Also, the release assertions still need to be removed because of the backup queue.
Comment 4 Ryosuke Niwa 2016-11-16 19:57:28 PST 
Created attachment 295020 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-11-16 20:32:55 PST 
Comment on attachment 295020 [details]
Patch for landing

Clearing flags on attachment: 295020

Committed r208837: <http://trac.webkit.org/changeset/208837>
Comment 6 WebKit Commit Bot 2016-11-16 20:33:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2016-11-18 20:25:48 PST 
Reverted r208837 for reason:

The bots did not show a progression

Committed r208917: <http://trac.webkit.org/changeset/208917>