WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
164852
REGRESSION(
r208082
): 1% Speedometer regression on iOS
https://bugs.webkit.org/show_bug.cgi?id=164852
Summary
REGRESSION(r208082): 1% Speedometer regression on iOS
Ryosuke Niwa
Reported
2016-11-16 19:18:48 PST
Temporarily disable CEReactions entirely to recover this regression.
Attachments
Patch
(8.12 KB, patch)
2016-11-16 19:28 PST
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Patch for landing
(8.40 KB, patch)
2016-11-16 19:57 PST
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2016-11-16 19:28:39 PST
Created
attachment 295018
[details]
Patch
Chris Dumez
Comment 2
2016-11-16 19:37:16 PST
Comment on
attachment 295018
[details]
Patch I don't mind this but wouldn't be be simpler/better to comment out support for [CEReactions] in the bindings generator?
Ryosuke Niwa
Comment 3
2016-11-16 19:45:15 PST
(In reply to
comment #2
)
> Comment on
attachment 295018
[details]
> Patch > > I don't mind this but wouldn't be be simpler/better to comment out support > for [CEReactions] in the bindings generator?
There are CustomElementReactionStack allocated in custom binding code as well. Also, the release assertions still need to be removed because of the backup queue.
Ryosuke Niwa
Comment 4
2016-11-16 19:57:28 PST
Created
attachment 295020
[details]
Patch for landing
WebKit Commit Bot
Comment 5
2016-11-16 20:32:55 PST
Comment on
attachment 295020
[details]
Patch for landing Clearing flags on attachment: 295020 Committed
r208837
: <
http://trac.webkit.org/changeset/208837
>
WebKit Commit Bot
Comment 6
2016-11-16 20:33:00 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 7
2016-11-18 20:25:48 PST
Reverted
r208837
for reason: The bots did not show a progression Committed
r208917
: <
http://trac.webkit.org/changeset/208917
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug