Bug 164851 - Add an experimental API to find elements across shadow boundaries
Summary: Add an experimental API to find elements across shadow boundaries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-16 19:16 PST by Ryosuke Niwa
Modified: 2016-11-17 21:30 PST (History)
11 users (show)

See Also:

Attachments
Adds the feature (32.24 KB, patch)
2016-11-16 19:49 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed build (33.43 KB, patch)
2016-11-16 21:37 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Dropped the prefix (42.26 KB, patch)
2016-11-17 20:15 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-11-16 19:16:21 PST 
Add an experimental API to find elements that match a given selector across shadow boundaries.
Comment 1 Ryosuke Niwa 2016-11-16 19:17:11 PST 
<rdar://problem/28220092>
Comment 2 Ryosuke Niwa 2016-11-16 19:49:15 PST 
Created attachment 295019 [details]
Adds the feature
Comment 3 Ryosuke Niwa 2016-11-16 21:37:37 PST 
Created attachment 295025 [details]
Fixed build
Comment 4 Sam Weinig 2016-11-16 23:02:34 PST 
Comment on attachment 295025 [details]
Fixed build

View in context: https://bugs.webkit.org/attachment.cgi?id=295025&action=review

> Source/WebCore/ChangeLog:9
> +        Add window.webkitCollectMatchingElementsAcrossShadowBoundaries(Node node, DOMString selectors)

What's the argument for prefixing this?
Comment 5 Ryosuke Niwa 2016-11-16 23:06:46 PST 
(In reply to comment #4)
> Comment on attachment 295025 [details]
> Fixed build
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295025&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Add window.webkitCollectMatchingElementsAcrossShadowBoundaries(Node node, DOMString selectors)
> 
> What's the argument for prefixing this?

I think the argument is that this is a proprietary API we don't intend to standardize.
Comment 6 Ryosuke Niwa 2016-11-17 20:15:14 PST 
Created attachment 295131 [details]
Dropped the prefix
Comment 7 Ryosuke Niwa 2016-11-17 21:05:08 PST 
Comment on attachment 295131 [details]
Dropped the prefix

Thanks for the review!
Comment 8 WebKit Commit Bot 2016-11-17 21:30:31 PST 
Comment on attachment 295131 [details]
Dropped the prefix

Clearing flags on attachment: 295131

Committed r208878: <http://trac.webkit.org/changeset/208878>
Comment 9 WebKit Commit Bot 2016-11-17 21:30:37 PST 
All reviewed patches have been landed.  Closing bug.