Bug 164846 – [SVG -> OTF Font Converter] Fonts advances are not internally consistent inside the generated font file

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[SVG -> OTF Font Converter]

[Myles C. Maxfield]

Created attachment 295004 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/29031509>

[Build Bot]

Comment on attachment 295004 [details]
Patch

Attachment 295004 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2528635

New failing tests:
svg/W3C-SVG-1.1/text-intro-03-b.svg

[Build Bot]

Created attachment 295009 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295004 [details]
Patch

Attachment 295004 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2528666

New failing tests:
svg/W3C-SVG-1.1/fonts-elem-04-b.svg
svg/W3C-SVG-1.1/text-intro-03-b.svg

[Build Bot]

Created attachment 295011 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295004 [details]
Patch

Attachment 295004 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2528642

New failing tests:
svg/W3C-SVG-1.1/fonts-elem-04-b.svg
svg/W3C-SVG-1.1/text-intro-03-b.svg

[Build Bot]

Created attachment 295012 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295004 [details]
Patch

Attachment 295004 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2528650

New failing tests:
svg/batik/text/textPosition2.svg
svg/batik/text/textEffect3.svg
svg/W3C-SVG-1.1/fonts-elem-02-t.svg
svg/W3C-SVG-1.1/text-intro-03-b.svg
svg/W3C-SVG-1.1/text-intro-04-t.svg
svg/W3C-SVG-1.1/fonts-elem-01-t.svg
svg/W3C-SVG-1.1/text-intro-02-b.svg
svg/W3C-SVG-1.1/fonts-elem-07-b.svg
svg/W3C-SVG-1.1/fonts-elem-04-b.svg
svg/W3C-SVG-1.1/text-intro-01-t.svg
svg/batik/text/textEffect.svg
svg/W3C-SVG-1.1/fonts-elem-03-b.svg

[Build Bot]

Created attachment 295013 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 295120 [details]
Patch

[Build Bot]

Comment on attachment 295120 [details]
Patch

Attachment 295120 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2534676

New failing tests:
svg/W3C-SVG-1.1/fonts-elem-04-b.svg

[Build Bot]

Created attachment 295127 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Darin Adler]

Comment on attachment 295120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295120&action=review

> Source/WebCore/svg/SVGToOTFFontConversion.cpp:1152
> +        writeCFFEncodedNumber(m_cffData, std::floor(width)); // hmtx table can't encode fractional FUnit values, and the CFF table needs to agree with hmtx.

How did you decide on floor rather than round?

[Build Bot]

Comment on attachment 295120 [details]
Patch

Attachment 295120 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2534790

New failing tests:
svg/W3C-SVG-1.1/fonts-elem-04-b.svg

[Build Bot]

Created attachment 295130 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Myles C. Maxfield]

Comment on attachment 295120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295120&action=review

>> Source/WebCore/svg/SVGToOTFFontConversion.cpp:1152
>> +        writeCFFEncodedNumber(m_cffData, std::floor(width)); // hmtx table can't encode fractional FUnit values, and the CFF table needs to agree with hmtx.
> 
> How did you decide on floor rather than round?

appendHMTXTable() uses clampTo() which has this behavior.

[Myles C. Maxfield]

Created attachment 295162 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 295162 [details]
Patch for committing

Clearing flags on attachment: 295162

Committed r208888: <http://trac.webkit.org/changeset/208888>