Bug 164845 – Fix build on macOS Sierra when WEB_PLAYBACK_CONTROLS_MANAGER is enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Ryosuke Niwa]

It looks like https://trac.webkit.org/changeset/208802 broke builds on macOS Sierra.

[Ryosuke Niwa]

Created attachment 295001 [details]
Patch

Why is this the right fix?

[Ryosuke Niwa]

(In reply to comment #2)
> Why is this the right fix?

This is similar to the fix we deployed in AVKit.h but I'm all ears if you have a better fix.

[Ryosuke Niwa]

By the way, I've already committed this in https://trac.webkit.org/changeset/208833.

(In reply to comment #3)
> (In reply to comment #2)
> > Why is this the right fix?
> 
> This is similar to the fix we deployed in AVKit.h but I'm all ears if you
> have a better fix.

I don’t know what you’re referring to (AVKit.h is not in the WebKit source tree, is it?). When the Apple Internal SDK isn’t available, we normally use declarations in a *SPI.h header file rather than omit functionality from the build.

[Ryosuke Niwa]

(In reply to comment #5)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Why is this the right fix?
> > 
> > This is similar to the fix we deployed in AVKit.h but I'm all ears if you
> > have a better fix.
> 
> I don’t know what you’re referring to (AVKit.h is not in the WebKit source
> tree, is it?). When the Apple Internal SDK isn’t available, we normally use
> declarations in a *SPI.h header file rather than omit functionality from the
> build.

Sorry, I meant to say AVKitSPI.h

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > (In reply to comment #2)
> > > > Why is this the right fix?
> > > 
> > > This is similar to the fix we deployed in AVKit.h but I'm all ears if you
> > > have a better fix.
> > 
> > I don’t know what you’re referring to (AVKit.h is not in the WebKit source
> > tree, is it?). When the Apple Internal SDK isn’t available, we normally use
> > declarations in a *SPI.h header file rather than omit functionality from the
> > build.
> 
> Sorry, I meant to say AVKitSPI.h

What’s guarded with #if USE(APPLE_INTERNAL_SDK) in AVKitSPI.h are just #import statements for headers that are only available in the Apple-internal SDK, and the #else clause provides equivalent declarations. What attachment 295001 [details] guards with #if USE(APPLE_INTERNAL_SDK) are parts of the implementation, and the #else clauses don’t seem to be equivalent.

[Ryosuke Niwa]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (In reply to comment #3)
> > > > (In reply to comment #2)
> > > > > Why is this the right fix?
> > > > 
> > > > This is similar to the fix we deployed in AVKit.h but I'm all ears if you
> > > > have a better fix.
> > > 
> > > I don’t know what you’re referring to (AVKit.h is not in the WebKit source
> > > tree, is it?). When the Apple Internal SDK isn’t available, we normally use
> > > declarations in a *SPI.h header file rather than omit functionality from the
> > > build.
> > 
> > Sorry, I meant to say AVKitSPI.h
> 
> What’s guarded with #if USE(APPLE_INTERNAL_SDK) in AVKitSPI.h are just
> #import statements for headers that are only available in the Apple-internal
> SDK, and the #else clause provides equivalent declarations. What attachment
> 295001 [details] guards with #if USE(APPLE_INTERNAL_SDK) are parts of the
> implementation, and the #else clauses don’t seem to be equivalent.

Oh I see. So you think the correct fix is to declare the missing properties in AVKitSPI.h instead?

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > (In reply to comment #5)
> > > > (In reply to comment #3)
> > > > > (In reply to comment #2)
> > > > > > Why is this the right fix?
> > > > > 
> > > > > This is similar to the fix we deployed in AVKit.h but I'm all ears if you
> > > > > have a better fix.
> > > > 
> > > > I don’t know what you’re referring to (AVKit.h is not in the WebKit source
> > > > tree, is it?). When the Apple Internal SDK isn’t available, we normally use
> > > > declarations in a *SPI.h header file rather than omit functionality from the
> > > > build.
> > > 
> > > Sorry, I meant to say AVKitSPI.h
> > 
> > What’s guarded with #if USE(APPLE_INTERNAL_SDK) in AVKitSPI.h are just
> > #import statements for headers that are only available in the Apple-internal
> > SDK, and the #else clause provides equivalent declarations. What attachment
> > 295001 [details] guards with #if USE(APPLE_INTERNAL_SDK) are parts of the
> > implementation, and the #else clauses don’t seem to be equivalent.
> 
> Oh I see. So you think the correct fix is to declare the missing properties
> in AVKitSPI.h instead?

I don’t know what the original build error was, but if there’s anything that’s declared in one of the Apple-internal headers that AVKitSPI.h imports, and that declaration is missing from the #else clause, and adding it would fix the build, then in principle that’s the right fix :-)

[Ryosuke Niwa]

Reopening this to fix this properly.

[Ryosuke Niwa]

Created attachment 295026 [details]
Fixes the build properly

[Ryosuke Niwa]

Committed r208838: <http://trac.webkit.org/changeset/208838>