[JSC] enable ES2017_ASYNCFUNCTION_SYNTAX feature flag
Created attachment 294960 [details] Patch
Comment on attachment 294960 [details] Patch my vote is to remove the compile time flag.
Comment on attachment 294960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294960&action=review I'm ok. I want Saam's review too :) > JSTests/ChangeLog:21 > + * test262.yaml: Async functions' YAML file should be dropped.
Comment on attachment 294960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294960&action=review >> JSTests/ChangeLog:21 >> + * test262.yaml: > > Async functions' YAML file should be dropped. Personally, I'd prefer to keep it until I'm no longer working on this feature, it saves a lot of time maintaining it. Up to you guys tho.
(In reply to comment #2) > Comment on attachment 294960 [details] > Patch > > my vote is to remove the compile time flag. I would suggest landing a flag flip CL first, with a second patch to remove the flag entirely separately, so that it's easier to go back to a flagged status if needed
(In reply to comment #5) > (In reply to comment #2) > > Comment on attachment 294960 [details] > > Patch > > > > my vote is to remove the compile time flag. > > I would suggest landing a flag flip CL first, with a second patch to remove > the flag entirely separately, so that it's easier to go back to a flagged > status if needed Dropping the compile time flag is not difficult to be reverted. So I like the suggestion dropping the compile time flag in this patch. If the compile time flag is enabled, disabled version tends to be broken soon (Unfortunately!). So even if we have the compile time flag, disabling it may take some more work beyond flipping the flag.
Comment on attachment 294960 [details] Patch Patches that have been up for review since 2016 are almost certainly too stale to be relevant to trunk in their current form. If this patch is still important please rebase it and post it for review again.