Bug 164821 – [CSS Parser] Add @supports, @keyframe and media query parsing options

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dave Hyatt]

[CSS Parser] Add @supports, @keyframe and media query parsing otions

[Dave Hyatt]

Created attachment 294943 [details]
Patch

[zalan]

Comment on attachment 294943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294943&action=review

> Source/WebCore/css/CSSKeyframeRule.cpp:77
> +    std::unique_ptr<Vector<double>> keys = CSSParser::parseKeyframeKeyList(keyText);

auto?

> Source/WebCore/css/MediaList.cpp:138
> +            --i;

What happens when i == 0?

[Build Bot]

Comment on attachment 294943 [details]
Patch

Attachment 294943 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2526271

New failing tests:
fast/media/mq-js-media-except-03.html
fast/media/mq-invalid-syntax-02.html
fast/media/mq-js-stylesheet-media-01.html
fast/media/mq-invalid-syntax-05.html
fast/media/mq-invalid-syntax-01.html
fast/media/mq-js-stylesheet-media-03.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
fast/media/mq-js-media-except-02.html
fast/media/mq-js-stylesheet-media-02.html
fast/media/mq-js-media-forward-syntax.html

[Build Bot]

Created attachment 294947 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 294943 [details]
Patch

Attachment 294943 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2526298

New failing tests:
fast/media/mq-js-media-except-03.html
fast/media/mq-invalid-syntax-02.html
fast/media/mq-js-stylesheet-media-01.html
fast/media/mq-invalid-syntax-05.html
fast/media/mq-js-stylesheet-media-02.html
fast/media/mq-invalid-syntax-01.html
fast/media/mq-js-stylesheet-media-03.html
fast/media/mq-js-media-except-02.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
fast/media/mq-js-media-forward-syntax.html

[Build Bot]

Created attachment 294949 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 294943 [details]
Patch

Attachment 294943 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2526338

New failing tests:
fast/media/mq-js-media-except-03.html
fast/media/mq-invalid-syntax-02.html
fast/media/mq-js-stylesheet-media-01.html
fast/media/mq-invalid-syntax-05.html
fast/media/mq-invalid-syntax-01.html
fast/media/mq-js-stylesheet-media-03.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
fast/media/mq-js-media-except-02.html
fast/media/mq-js-stylesheet-media-02.html
fast/media/mq-js-media-forward-syntax.html

[Build Bot]

Created attachment 294950 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Dave Hyatt]

Created attachment 294966 [details]
Patch

[Dave Hyatt]

Created attachment 294971 [details]
Patch

[Dave Hyatt]

Created attachment 294975 [details]
Patch

[Sam Weinig]

Comment on attachment 294975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294975&action=review

> Source/WebCore/css/CSSKeyframesRule.cpp:77
> +    std::unique_ptr<Vector<double>> keys = CSSParser::parseKeyframeKeyList(key);

Could use auto here to avoid this mouthful of a type name.

> Source/WebCore/css/MediaList.cpp:99
>  bool MediaQuerySet::add(const String& queryString)

If this and set always return true, can we get rid of the return value? Or should we still be returning false in some cases, like if the media query is invalid?

> Source/WebCore/css/MediaList.cpp:193
> +    if (!m_mediaQueries->set(value))
>          return Exception { SYNTAX_ERR };

Set always returns true, no need for this condition.

> Source/WebCore/css/StyleMedia.cpp:70
> +    if (!media->set(query))
>          return false;

Set always returns true, no need for this condition.

[Dave Hyatt]

Landed in r208847.