We should move the special case code in the bindings for SVG list types into the implementation.
Created attachment 294877 [details] Patch
Attachment 294877 [details] did not pass style-queue: ERROR: Source/WebCore/svg/SVGNumberListValues.cpp:38: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/svg/SVGAnimatedPointList.h:28: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WebCore/svg/SVGTransformListValues.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/svg/SVGPathSegList.cpp:35: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/svg/SVGPathSegList.h:129: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/svg/SVGPathSegList.h:138: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/svg/SVGPathSegList.h:144: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/svg/SVGPathSegList.h:151: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/svg/SVGTransformable.h:41: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 10 in 93 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 294905 [details] Patch
Attachment 294905 [details] did not pass style-queue: ERROR: Source/WebCore/svg/SVGNumberListValues.cpp:38: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/svg/SVGAnimatedPointList.h:28: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WebCore/svg/SVGTransformListValues.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/svg/SVGPathSegList.cpp:35: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/svg/SVGPathSegList.h:129: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/svg/SVGPathSegList.h:138: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/svg/SVGPathSegList.h:144: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/svg/SVGPathSegList.h:151: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/svg/SVGTransformable.h:41: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 10 in 93 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 294906 [details] Patch
Attachment 294906 [details] did not pass style-queue: ERROR: Source/WebCore/svg/SVGPathSegList.h:129: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/svg/SVGPathSegList.h:138: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/svg/SVGPathSegList.h:144: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/svg/SVGPathSegList.h:151: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 4 in 93 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 294906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294906&action=review > Source/WebCore/svg/SVGLengthListValues.cpp:60 > + if (i > 0) > 0 unnecessary > Source/WebCore/svg/SVGNumberListValues.cpp:52 > + if (i > 0) ditto > Source/WebCore/svg/SVGPathSegList.h:47 > + int findItem(const ListItemType& item) const This could be an Optional<unsigned> > Source/WebCore/svg/SVGPointListValues.cpp:35 > + if (i > 0) ditto > Source/WebCore/svg/SVGTransformListValues.cpp:65 > + if (i > 0) ditto
Committed r208863: <http://trac.webkit.org/changeset/208863>