Sometimes when I try to select text in Safari on Windows, the selection starts a few characters after I start dragging my mouse. This looks like it's because EventHandler::dragState().m_dragSrc does not get cleared between mouse downs. In WebCore/page/mac/EventHandlerMac.mm, this gets nulled out in EventHandler::mouseDown. Since it seems like this value needs to be reset on all platforms, maybe it should be moved into EventHandler::handleMousePressEvent? Test case coming up...
Created attachment 17968 [details] test case In the above test case, click on the link then try to select some text. Sometimes the text selection doesn't start until we're a few lines/characters away from the mouse down.
Created attachment 17970 [details] clear m_dragSrc on all platforms
(In reply to comment #2) > Created an attachment (id=17970) [edit] > clear m_dragSrc on all platforms Please set review? flag on patches to make sure they're reviewed!
The test needs a layoutTestController.dumpAsText() call - otherwise, it will generate platform-dependent pixel results when run-webkit-tests is run with a --pixel option.
Created attachment 18000 [details] use dumpAsText I updated the test to use dumpAsText instead. We need to ensure that something is selected.
Fix looks good for the GTK+ port.
Comment on attachment 18000 [details] use dumpAsText r=me
Landed in r28888.