Bug 164785 - Simplify Element::stripScriptingAttributes()
Summary: Simplify Element::stripScriptingAttributes()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-15 12:55 PST by Chris Dumez
Modified: 2016-11-15 20:07 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2016-11-15 12:57 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (deleted)
2016-11-15 16:09 PST, Build Bot 		no flags Details
Patch (2.04 KB, patch)
2016-11-15 16:12 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.05 KB, patch)
2016-11-15 16:16 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2016-11-15 16:19 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-11-15 12:55:31 PST 
Simplify Element::stripScriptingAttributes() by leveraging Vector::removeAllMatching().
Comment 1 Chris Dumez 2016-11-15 12:57:16 PST 
Created attachment 294869 [details]
Patch
Comment 2 Build Bot 2016-11-15 16:08:59 PST 
Comment on attachment 294869 [details]
Patch

Attachment 294869 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2522198

New failing tests:
js/regress-141098.html
Comment 3 Build Bot 2016-11-15 16:09:04 PST 
Created attachment 294892 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 4 Chris Dumez 2016-11-15 16:12:57 PST 
Created attachment 294894 [details]
Patch
Comment 5 Chris Dumez 2016-11-15 16:16:48 PST 
Created attachment 294896 [details]
Patch
Comment 6 Chris Dumez 2016-11-15 16:19:10 PST 
Created attachment 294897 [details]
Patch
Comment 7 Ryosuke Niwa 2016-11-15 16:45:06 PST 
Be sure this doesn't slow down the copy & paste.
Comment 8 Chris Dumez 2016-11-15 16:46:58 PST 
(In reply to comment #7)
> Be sure this doesn't slow down the copy & paste.

Vector::removeAllMatching() is extremely efficient.
Comment 9 WebKit Commit Bot 2016-11-15 20:07:35 PST 
Comment on attachment 294897 [details]
Patch

Clearing flags on attachment: 294897

Committed r208780: <http://trac.webkit.org/changeset/208780>
Comment 10 WebKit Commit Bot 2016-11-15 20:07:40 PST 
All reviewed patches have been landed.  Closing bug.