RESOLVED FIXED 164785
Simplify Element::stripScriptingAttributes() 
https://bugs.webkit.org/show_bug.cgi?id=164785
Summary Simplify Element::stripScriptingAttributes()
Chris Dumez
Reported 2016-11-15 12:55:31 PST
Simplify Element::stripScriptingAttributes() by leveraging Vector::removeAllMatching().
Attachments
Patch (2.03 KB, patch)
2016-11-15 12:57 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (deleted)
2016-11-15 16:09 PST, Build Bot 		no flags
Details
Patch (2.04 KB, patch)
2016-11-15 16:12 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.05 KB, patch)
2016-11-15 16:16 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.04 KB, patch)
2016-11-15 16:19 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-11-15 12:57:16 PST
Created attachment 294869 [details] Patch
Build Bot
Comment 2 2016-11-15 16:08:59 PST
Comment on attachment 294869 [details] Patch Attachment 294869 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2522198 New failing tests: js/regress-141098.html
Build Bot
Comment 3 2016-11-15 16:09:04 PST
Created attachment 294892 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Chris Dumez
Comment 4 2016-11-15 16:12:57 PST
Created attachment 294894 [details] Patch
Chris Dumez
Comment 5 2016-11-15 16:16:48 PST
Created attachment 294896 [details] Patch
Chris Dumez
Comment 6 2016-11-15 16:19:10 PST
Created attachment 294897 [details] Patch
Ryosuke Niwa
Comment 7 2016-11-15 16:45:06 PST
Be sure this doesn't slow down the copy & paste.
Chris Dumez
Comment 8 2016-11-15 16:46:58 PST
(In reply to comment #7) > Be sure this doesn't slow down the copy & paste. Vector::removeAllMatching() is extremely efficient.
WebKit Commit Bot
Comment 9 2016-11-15 20:07:35 PST
Comment on attachment 294897 [details] Patch Clearing flags on attachment: 294897 Committed r208780: <http://trac.webkit.org/changeset/208780>
WebKit Commit Bot
Comment 10 2016-11-15 20:07:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.