Bug 164782 – [WebGL] Remove unused Chromium-specific OpenGL extensions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[WebGL] Remove unused Chromium-specific OpenGL extensions

[Myles C. Maxfield]

Created attachment 294856 [details]
Patch

[Myles C. Maxfield]

Created attachment 294859 [details]
Patch

[Dean Jackson]

Comment on attachment 294856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294856&action=review

> Source/WebCore/html/canvas/WebGLDrawBuffers.cpp:107
> +    bool supportsDepth = (context->getExtensions()->supports("GL_OES_depth_texture")

We don't really need the outer () here.

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1373
> +            zero = std::make_unique<unsigned char[]>(size);

I wonder if we should change this to use JSC::Uint8Array::create? Aren't they zero filled anyway?

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1809
> +    // Ensure we have a valid rendering state

Nit: .

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1874
> +    // Ensure we have a valid rendering state

Nit: .

[Myles C. Maxfield]

Comment on attachment 294856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294856&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1373
>> +            zero = std::make_unique<unsigned char[]>(size);
> 
> I wonder if we should change this to use JSC::Uint8Array::create? Aren't they zero filled anyway?

Why Uint8Array? It's just a temporary buffer that goes away immediately; if anything, it should be a Vector<uint8_t>.

[Myles C. Maxfield]

Created attachment 294861 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 294861 [details]
Patch for committing

Rejecting attachment 294861 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 294861, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2521215

[Myles C. Maxfield]

Created attachment 294862 [details]
Patch for committing

[Myles C. Maxfield]

Committed r208747: <http://trac.webkit.org/changeset/208747>