Bug 164782 - [WebGL] Remove unused Chromium-specific OpenGL extensions
Summary: [WebGL] Remove unused Chromium-specific OpenGL extensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-15 11:29 PST by Myles C. Maxfield
Modified: 2016-11-15 12:55 PST (History)
12 users (show)

See Also:

Attachments
Patch (31.68 KB, patch)
2016-11-15 11:30 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (31.60 KB, patch)
2016-11-15 11:33 PST, Myles C. Maxfield 		dino: review+
Details | Formatted Diff | Diff
Patch for committing (31.68 KB, patch)
2016-11-15 11:56 PST, Myles C. Maxfield 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (31.68 KB, patch)
2016-11-15 12:07 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-11-15 11:29:28 PST 
[WebGL] Remove unused Chromium-specific OpenGL extensions
Comment 1 Myles C. Maxfield 2016-11-15 11:30:09 PST 
Created attachment 294856 [details]
Patch
Comment 2 Myles C. Maxfield 2016-11-15 11:33:39 PST 
Created attachment 294859 [details]
Patch
Comment 3 Dean Jackson 2016-11-15 11:39:58 PST 
Comment on attachment 294856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294856&action=review

> Source/WebCore/html/canvas/WebGLDrawBuffers.cpp:107
> +    bool supportsDepth = (context->getExtensions()->supports("GL_OES_depth_texture")

We don't really need the outer () here.

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1373
> +            zero = std::make_unique<unsigned char[]>(size);

I wonder if we should change this to use JSC::Uint8Array::create? Aren't they zero filled anyway?

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1809
> +    // Ensure we have a valid rendering state

Nit: .

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1874
> +    // Ensure we have a valid rendering state

Nit: .
Comment 4 Myles C. Maxfield 2016-11-15 11:52:22 PST 
Comment on attachment 294856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294856&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1373
>> +            zero = std::make_unique<unsigned char[]>(size);
> 
> I wonder if we should change this to use JSC::Uint8Array::create? Aren't they zero filled anyway?

Why Uint8Array? It's just a temporary buffer that goes away immediately; if anything, it should be a Vector<uint8_t>.
Comment 5 Myles C. Maxfield 2016-11-15 11:56:26 PST 
Created attachment 294861 [details]
Patch for committing
Comment 6 WebKit Commit Bot 2016-11-15 11:58:30 PST 
Comment on attachment 294861 [details]
Patch for committing

Rejecting attachment 294861 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 294861, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2521215
Comment 7 Myles C. Maxfield 2016-11-15 12:07:52 PST 
Created attachment 294862 [details]
Patch for committing
Comment 8 Myles C. Maxfield 2016-11-15 12:55:35 PST 
Committed r208747: <http://trac.webkit.org/changeset/208747>