Bug 164781 - The jsc shell's setImpureGetterDelegate() should ensure that the set value is an ImpureGetter.
Summary: The jsc shell's setImpureGetterDelegate() should ensure that the set value is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-15 11:17 PST by Mark Lam
Modified: 2016-11-15 11:45 PST (History)
5 users (show)

See Also:

Attachments
proposed patch. (3.40 KB, patch)
2016-11-15 11:30 PST, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-11-15 11:17:47 PST 
Patch coming.
Comment 1 Mark Lam 2016-11-15 11:18:23 PST 
<rdar://problem/28418590>
Comment 2 Mark Lam 2016-11-15 11:30:18 PST 
Created attachment 294857 [details]
proposed patch.
Comment 3 Geoffrey Garen 2016-11-15 11:33:20 PST 
Comment on attachment 294857 [details]
proposed patch.

r=me
Comment 4 Michael Saboff 2016-11-15 11:35:31 PST 
Comment on attachment 294857 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=294857&action=review

> JSTests/stress/jsc-setImpureGetterDelegate-on-bad-type.js:2
> +// This test passes if it does not crash or triggers any assertion failures.

How about "trigger" singular?
Comment 5 Mark Lam 2016-11-15 11:36:49 PST 
(In reply to comment #4)
> Comment on attachment 294857 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=294857&action=review
> 
> > JSTests/stress/jsc-setImpureGetterDelegate-on-bad-type.js:2
> > +// This test passes if it does not crash or triggers any assertion failures.
> 
> How about "trigger" singular?

Thanks.  Fixed.
Comment 6 Mark Lam 2016-11-15 11:45:30 PST 
Thanks for the reviews.  Landed in r208741: <http://trac.webkit.org/r208741>.