WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
164777
Remove JSString::SafeView and replace its uses with StringViewWithUnderlyingString.
https://bugs.webkit.org/show_bug.cgi?id=164777
Summary
Remove JSString::SafeView and replace its uses with StringViewWithUnderlyingS...
Mark Lam
Reported
2016-11-15 09:37:55 PST
JSString::SafeView no longer achieves its intended goal to make it easier to handle strings safely. Its clients still need to do explicit exception checks in order to be correct. We'll remove it and replace its uses with StringViewWithUnderlyingString instead which serves to gets the a StringView (which is what we really wanted from SafeView) and keeps the backing String alive while the view is in use.
Attachments
proposed patch.
(14.95 KB, patch)
2016-11-15 09:52 PST
,
Mark Lam
no flags
Details
Formatted Diff
Diff
proposed patch.
(15.45 KB, patch)
2016-11-15 09:54 PST
,
Mark Lam
ggaren
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2016-11-15 09:52:06 PST
Created
attachment 294845
[details]
proposed patch.
Mark Lam
Comment 2
2016-11-15 09:54:17 PST
Created
attachment 294846
[details]
proposed patch.
Geoffrey Garen
Comment 3
2016-11-15 15:11:19 PST
Comment on
attachment 294846
[details]
proposed patch. r=me
Mark Lam
Comment 4
2016-11-15 16:20:57 PST
Thanks for the review. Landed in
r208767
: <
http://trac.webkit.org/r208767
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug