WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
164772
[Win] WebCore test is failing.
https://bugs.webkit.org/show_bug.cgi?id=164772
Summary
[Win] WebCore test is failing.
Per Arne Vollan
Reported
2016-11-15 05:29:02 PST
A CG rectangle test is failing on Windows.
Attachments
Patch
(1.86 KB, patch)
2016-11-15 05:53 PST
,
Per Arne Vollan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Per Arne Vollan
Comment 1
2016-11-15 05:53:14 PST
Created
attachment 294833
[details]
Patch
Brent Fulgham
Comment 2
2016-11-15 09:51:04 PST
Comment on
attachment 294833
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=294833&action=review
r=me.
> Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp:719 > + EXPECT_FLOAT_EQ(std::numeric_limits<float>::max(), cgInfiniteRect.size.height);
*sigh*. I wonder if this was a change in CG behavior post Leopard, or if these have always been mismatched.
Per Arne Vollan
Comment 3
2016-11-16 00:45:02 PST
Comment on
attachment 294833
[details]
Patch Thanks for reviewing :)
WebKit Commit Bot
Comment 4
2016-11-16 01:08:28 PST
Comment on
attachment 294833
[details]
Patch Clearing flags on attachment: 294833 Committed
r208787
: <
http://trac.webkit.org/changeset/208787
>
WebKit Commit Bot
Comment 5
2016-11-16 01:08:31 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug