Bug 164772 - [Win] WebCore test is failing.
Summary: [Win] WebCore test is failing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-15 05:29 PST by Per Arne Vollan
Modified: 2016-11-16 01:08 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2016-11-15 05:53 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-11-15 05:29:02 PST 
A CG rectangle test is failing on Windows.
Comment 1 Per Arne Vollan 2016-11-15 05:53:14 PST 
Created attachment 294833 [details]
Patch
Comment 2 Brent Fulgham 2016-11-15 09:51:04 PST 
Comment on attachment 294833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294833&action=review

r=me.

> Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp:719
> +    EXPECT_FLOAT_EQ(std::numeric_limits<float>::max(), cgInfiniteRect.size.height);

*sigh*. I wonder if this was a change in CG behavior post Leopard, or if these have always been mismatched.
Comment 3 Per Arne Vollan 2016-11-16 00:45:02 PST 
Comment on attachment 294833 [details]
Patch

Thanks for reviewing :)
Comment 4 WebKit Commit Bot 2016-11-16 01:08:28 PST 
Comment on attachment 294833 [details]
Patch

Clearing flags on attachment: 294833

Committed r208787: <http://trac.webkit.org/changeset/208787>
Comment 5 WebKit Commit Bot 2016-11-16 01:08:31 PST 
All reviewed patches have been landed.  Closing bug.