Bug 164765 - [iOS WK2] Implement support for visual viewports
Summary: [iOS WK2] Implement support for visual viewports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 164260
  Show dependency tree / graph
 
Reported: 2016-11-14 21:17 PST by Simon Fraser (smfr)
Modified: 2016-11-15 14:45 PST (History)
12 users (show)

See Also:

Attachments
Patch (46.98 KB, patch)
2016-11-14 21:40 PST, Simon Fraser (smfr) 		thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (6.18 MB, application/zip)
2016-11-14 23:18 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-11-14 21:17:01 PST 
[iOS WK2] Implement support for visual viewports
Comment 1 Simon Fraser (smfr) 2016-11-14 21:40:19 PST 
Created attachment 294809 [details]
Patch
Comment 2 Build Bot 2016-11-14 23:18:28 PST 
Comment on attachment 294809 [details]
Patch

Attachment 294809 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2518107

New failing tests:
fast/visual-viewport/rtl-zoomed-rects.html
fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html
fast/visual-viewport/zoomed-rects.html
fast/visual-viewport/zoomed-fixed.html
Comment 3 Build Bot 2016-11-14 23:18:32 PST 
Created attachment 294820 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 4 Tim Horton 2016-11-15 10:15:55 PST 
Comment on attachment 294809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294809&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1277
> +    BOOL needUpdateVisbleContentRects = _page->updateLayoutViewportParameters(layerTreeTransaction);

VISBLE

> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:222
> +// FIXME: rename this when visual viewports are the default.

What's up with all the leading lowercase letters in your comments?
Comment 5 Simon Fraser (smfr) 2016-11-15 14:45:45 PST 
https://trac.webkit.org/changeset/208748