Bug 164763 - [WebCore] Drop frame protection for script execution
Summary: [WebCore] Drop frame protection for script execution
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2016-11-14 20:28 PST by Yusuke Suzuki
Modified: 2018-01-29 12:22 PST (History)
2 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-11-14 20:28:01 PST
In ScriptController and ScriptElement, there are some `Ref<Frame> protector(frame)` protections.
It avoids destroying Frame during executing scripts.

But if there are no code touching Frame after the execution of the script, we do not need to save Frame.
Comment 1 Yusuke Suzuki 2016-11-14 20:32:05 PST
Not in ScriptElement.
Comment 2 Michael Catanzaro 2018-01-29 12:22:10 PST
Be careful if changing this: the ScriptController is actually owned by its Frame, so removing protectors could cause the ScriptController itself to be destroyed.