Bug 164750 - CodeCache should stop pretending to cache builtins
Summary: CodeCache should stop pretending to cache builtins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-14 17:08 PST by Geoffrey Garen
Modified: 2016-11-15 11:04 PST (History)
5 users (show)

See Also:

Attachments
Patch (15.15 KB, patch)
2016-11-14 17:13 PST, Geoffrey Garen 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-11-14 17:08:44 PST 
CodeCache should stop pretending to cache builtins
Comment 1 Geoffrey Garen 2016-11-14 17:13:04 PST 
Created attachment 294778 [details]
Patch
Comment 2 Saam Barati 2016-11-14 17:20:35 PST 
Comment on attachment 294778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294778&action=review

r=me

> Source/JavaScriptCore/parser/SourceCodeKey.h:-48
> -            (static_cast<unsigned>(builtinMode) << 1) |

Maybe it's worth updating the other shifts to be subtracted by 1?
Comment 3 Geoffrey Garen 2016-11-15 11:04:25 PST 
Committed r208736: <http://trac.webkit.org/changeset/208736>