Bug 164746 – Update SubtleCrypto::wrapKey to match the latest spec

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

Update SubtleCrypto::wrapKey to match the latest spec.

[Radar WebKit Bug Importer]

<rdar://problem/29258160>

[Jiewen Tan]

Created attachment 295626 [details]
Patch

[WebKit Commit Bot]

Attachment 295626 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:161:  CryptoAlgorithmAES_KW::wrapKey is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp:36:  CryptoAlgorithmAES_KW::platformWrapKey is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmAES_KWMac.cpp:39:  wrapKeyAES_KW is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmAES_KWMac.cpp:50:  CryptoAlgorithmAES_KW::platformWrapKey is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 4 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Comment on attachment 295626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295626&action=review

r=me

> Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:651
> +    supportExportKeyThrow(state, key->algorithmIdentifier());

Is it okay that we are changing from this promise rejection to a DOM exception? Is that per the new specification?

> LayoutTests/imported/w3c/WebCryptoAPI/idlharness-expected.txt:67
> +PASS SubtleCrypto interface: calling wrapKey(KeyFormat,CryptoKey,CryptoKey,AlgorithmIdentifier) on crypto.subtle with too few arguments must throw TypeError 

Ever closer! I hope to see 'unwrapKey' soon! :-)

[Jiewen Tan]

Comment on attachment 295626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295626&action=review

Thanks Brent for r+ my patch.

>> Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:651
>> +    supportExportKeyThrow(state, key->algorithmIdentifier());
> 
> Is it okay that we are changing from this promise rejection to a DOM exception? Is that per the new specification?

Don't worry. There is a catcher in callPromiseFunction to convert any thrown exceptions to rejected promises.

[WebKit Commit Bot]

Comment on attachment 295626 [details]
Patch

Clearing flags on attachment: 295626

Committed r209155: <http://trac.webkit.org/changeset/209155>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.