Bug 164735 - Expected: add missing `inline`
Summary: Expected: add missing `inline`
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-14 15:28 PST by JF Bastien
Modified: 2016-11-14 16:13 PST (History)
7 users (show)

See Also:


Attachments
patch (2.41 KB, patch)
2016-11-14 15:32 PST, JF Bastien
no flags Details | Formatted Diff | Diff
patch (2.40 KB, patch)
2016-11-14 15:37 PST, JF Bastien
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2016-11-14 15:28:30 PST
Free functions and full template specializations need to be `static inline`, or in a .cpp file, otherwise each .o creates a duplicate symbol which makes the linker very sad.
Comment 1 JF Bastien 2016-11-14 15:32:13 PST
Created attachment 294759 [details]
patch
Comment 2 JF Bastien 2016-11-14 15:37:14 PST
Created attachment 294762 [details]
patch

Drop `static`, only `inline` is needed.
Comment 3 Yusuke Suzuki 2016-11-14 15:37:38 PST
Comment on attachment 294762 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2016-11-14 16:13:32 PST
Comment on attachment 294762 [details]
patch

Clearing flags on attachment: 294762

Committed r208713: <http://trac.webkit.org/changeset/208713>
Comment 5 WebKit Commit Bot 2016-11-14 16:13:37 PST
All reviewed patches have been landed.  Closing bug.