Patch forthcoming
Created attachment 294831 [details] Patch
Attachment 294831 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/ARMAssembler.h:218: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ping?
(In reply to comment #3) > Ping? Ping2
(In reply to comment #3) > Ping? Ping3
Comment on attachment 294831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294831&action=review > Source/JavaScriptCore/assembler/MacroAssemblerARM.h:-1482 > - please revert > Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:-1341 > - Please revert changes in this file.
(In reply to comment #6) > Comment on attachment 294831 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=294831&action=review > > > Source/JavaScriptCore/assembler/MacroAssemblerARM.h:-1482 > > - > > please revert > > > Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:-1341 > > - > > Please revert changes in this file. You meant only extra whitespace removal changes, don't you?
Comment on attachment 294831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294831&action=review >>> Source/JavaScriptCore/assembler/MacroAssemblerARM.h:-1482 >>> - >> >> please revert > > You meant only extra whitespace removal changes, don't you? Yes, that is what Saam meant. Normally, if whitespace changes are in the vicinity of the changed code, it'd be ok. But in this case, it seems unrelated to the patch. To keep the patch minimal and aligned to its intent, it is best to leave the whitespace changes to another patch. I think you can land the white space removal in a separate unreviewed patch if you like (just like we do for minor comment typo fix ups and build fixes).
Created attachment 296286 [details] Patch for landing
Attachment 296286 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/ARMAssembler.h:218: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 296286 [details] Patch for landing Clearing flags on attachment: 296286 Committed r209392: <http://trac.webkit.org/changeset/209392>