Bug 164728 - [CSS Parser] Support the font-synthesis property
Summary: [CSS Parser] Support the font-synthesis property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-14 13:28 PST by Dave Hyatt
Modified: 2016-11-14 13:40 PST (History)
0 users

See Also:


Attachments
Patch (2.32 KB, patch)
2016-11-14 13:29 PST, Dave Hyatt
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-11-14 13:28:05 PST
[CSS Parser] Support the font-synthesis property
Comment 1 Dave Hyatt 2016-11-14 13:29:05 PST
Created attachment 294735 [details]
Patch
Comment 2 Dean Jackson 2016-11-14 13:32:23 PST
Comment on attachment 294735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294735&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:806
> +    do {
> +        if (range.peek().id() == CSSValueWeight)
> +            weight = consumeIdent(range);
> +        else if (range.peek().id() == CSSValueStyle)
> +            style = consumeIdent(range);
> +        else
> +            return nullptr;
> +    } while (!range.atEnd());

What a weird property. font-synthesis: weight style weight weight weight; is fine.
Comment 3 Dave Hyatt 2016-11-14 13:40:33 PST
Landed in r208706.