Bug 164725 - [Mac][iOS][WK2] Tighten permissions to change CapsLock delay
Summary: [Mac][iOS][WK2] Tighten permissions to change CapsLock delay
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-14 12:16 PST by Brent Fulgham
Modified: 2016-11-14 13:47 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2016-11-14 12:18 PST, Brent Fulgham 		ap: review+
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-11-14 12:16:17 PST 
Tighten up the conditions under which we can adjust the Caps Lock delay. We only need this in specific instances, so why allow it all the time?
Comment 1 Brent Fulgham 2016-11-14 12:16:44 PST 
<rdar://problem/28970910>
Comment 2 Brent Fulgham 2016-11-14 12:18:05 PST 
Created attachment 294727 [details]
Patch
Comment 3 Alexey Proskuryakov 2016-11-14 13:35:06 PST 
Comment on attachment 294727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294727&action=review

> Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:319
> +    (allow iokit-set-properties (iokit-property "CapsLockDelayOverrideâ)))

This line has a smart quote.
Comment 4 Brent Fulgham 2016-11-14 13:47:36 PST 
Comment on attachment 294727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294727&action=review

>> Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:319
>> +    (allow iokit-set-properties (iokit-property "CapsLockDelayOverrideâ)))
> 
> This line has a smart quote.

Argh! Fixed.
Comment 5 Brent Fulgham 2016-11-14 13:47:47 PST 
Committed r208708: <http://trac.webkit.org/changeset/208708>